A feature defining fields, views, rules, services for App store distribution.

http://drupal.org/sandbox/konforti/1285312
git clone --branch master http://git.drupal.org:sandbox/konforti/1285312.git

It's a Drupal 7 module.

Thanks.

Comments

patrickd’s picture

patrickd commented
Status: Needs review » Needs work

Please do not push into the master branch, follow the instructions on naming conventions here:
http://drupal.org/node/1015226, git branching: http://drupal.org/node/1066342

Your readme is a little too short, you should explain about how to use it etc.
also it should be named README.txt

regards

konforti’s picture

konforti commented

I added some information to the README.txt and fix it.
I pushed it to the 7.x branch now.
git clone --branch 7.x http://git.drupal.org/sandbox/konforti/1285312.git

Thanks.

konforti’s picture

konforti commented
Status: Needs work » Needs review
patrickd’s picture

patrickd commented

"7.x" is for core releases.. you still not understanding the naming conventions, it has to be eg. "7.x-1.x".

delete the wrong branch with

git push origin :newfeature
git branch -d newfeature
konforti’s picture

konforti commented

I fixed branch name to 7.x-1.x.
git clone --branch 7.x-1.x http://git.drupal.org/sandbox/konforti/1285312.git

Thank you.

z.stolar’s picture

z.stolar commented
Status: Needs review » Reviewed & tested by the community

The problem with distributions is that it needs to be a first class project in order to be thoroughly tested. As far as coding standards, naming conventions etc, this project passes validation.
We need it out in the open so we can let people join the initiative of app stores in Drupal. Please see (and join!): http://groups.drupal.org/node/175329 and http://groups.drupal.org/open-app-standard

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented
Status: Reviewed & tested by the community » Needs work

I tried to review this today but it's a bit hard since it's largely (completely?) exported code. There are really two things I can review: README.txt and project page which both felt lacking.

http://drupalcode.org/sandbox/konforti/1285312.git/blob/refs/heads/7.x-1...

Please take a moment to make your README.txt follow the guidelines for in-project documentation.

http://drupal.org/node/1285312

Please take a moment to make your project page follow tips for a great project page.

konforti’s picture

konforti commented
Status: Needs work » Needs review

We fixed the README.txt and the project page as suggested.

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Status: Needs review » Reviewed & tested by the community

* lines in README.txt should not exceed 80 characters
* info file: does Features create the "datestamp" property? normally this is added by drupal.org packaging.

Otherwise looks good to me.

konforti’s picture

konforti commented

Fixed the README.txt (80 characters per line).
The datestamp is created by Features module, yes. It's seems to works fine as it in the "commerce downloads feature" http://drupalcode.org/project/commerce_downloads_feature.git/blob_plain/...

Thanks.

rfay’s picture

rfay
he,him
Primary language English
Location Palisade, CO, USA
commented
Status: Reviewed & tested by the community » Fixed

Git vetted user role granted! Thanks for your contributions and future contributions! Thanks to the reviewers, and thanks all for your patience with this process (we hope to make it easier soon).

konforti’s picture

konforti commented

Thank you all, for your time and effort.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.