At now by default editablefields for Drupal 7.x adds button "Click to edit" for each field.
But with 6.x-1.2 they adds floating "[edit]" link to each editable element, that don't eats the space and looks more comfortable.
I can't find the way to display edit link in editablefields 1.x for Drupal 7.x like in 1.2 for 6.x, so maybe it miss in core of module.
Can you add this feature in editablefields 1.x for Drupal 7.x?

CommentFileSizeAuthor
#9 editablefields-1285430-9.patch4.54 KBbfr
#7 editablefields-1285430-7.patch4.53 KBtim.plunkett
#5 editablefields-1285430-5.patch4.39 KBtim.plunkett
#3 editablefields-1285430-3.patch3.86 KBdags

Comments

damien tournoud’s picture

damien tournoud commented

This is the job of CSS... we could include a generic CSS in the module, if someone wants to contribute one :)

murz’s picture

murz
Primary language English
Location Yerevan, Armenia
commented

Seems that in 6.x-1.2 this done not with css only, but with javascript in editablefields.js:

  $('div.editablefields', context).filter('.clicktoedit').not('.editablefields-processed').each(function() {
    $(this).prepend(Drupal.settings.editablefields.clicktoedit_message);
    $(".editablefields_clicktoedit_message").fadeOut(3000);
    $(this).mouseover(function(){$(".editablefields_clicktoedit_message",this).fadeIn(500);});
    $(this).mouseout(function(){$(".editablefields_clicktoedit_message",this).fadeOut(500);});
    $(this).click(Drupal.editablefields.init);
  });

Maybe we can reuse this code?

dags’s picture

dags commented
Status: Active » Needs review
StatusFileSize
new editablefields-1285430-3.patch3.86 KB

Here's a first attempt. It adds an instance setting for "Click to edit style". The CSS is a work in progress, especially since the D6 was a link and this is a button.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented

I'm not sure which is easier, making a link behave like a submit button, or making a button look like a link.
And that depends on how closely this should mimic D6.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Title: editablefields: Click to edit as floating link » Click to edit as floating link
StatusFileSize
new editablefields-1285430-5.patch4.39 KB

Addressed an issue with #states/#dependency for the Views UI.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Assigned: Unassigned » tim.plunkett
Status: Needs review » Needs work

I have a new patch for this but I left it on my work VM so it'll have to wait until tomorrow morning.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Assigned: tim.plunkett » Unassigned
Status: Needs work » Needs review
StatusFileSize
new editablefields-1285430-7.patch4.53 KB

Adds a link with JS that triggers the submit button. Props to xjm for the suggestion.

Steven.Pescador’s picture

Steven.Pescador commented

Worked a treat for me! Cheers Tim & xjm.

bfr’s picture

bfr commented
StatusFileSize
new editablefields-1285430-9.patch4.54 KB

Great job! I added a little fade there to make it look nicer.

bfr’s picture

bfr commented

Any chances to to get this commited? I hate to have patched modules in the clients site.

dags’s picture

dags commented
Status: Needs review » Fixed

Thanks! Committed.
http://drupalcode.org/project/editablefields.git/commit/3d21d4b

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

murz’s picture

murz
Primary language English
Location Yerevan, Armenia
commented

As alternative we can use this module: http://drupal.org/project/editablefields_as_link