Advagg drupal code style issues [#1285886]

Comment	File	Size	Author
#6	advadd-1285886-6-coding-standards-output.patch	751.53 KB	doublejosh
#3	advagg-1285886-3.patch	24.16 KB	mikeytown2

Comment #1

mikeytown2 commented 21 September 2011 at 07:38

If you look at the module files there should be close to zero. If you include the library files then you will get the crazy count.

Log in or register to post comments

Comment #2

Anonymous (not verified) commented 27 September 2011 at 19:51

I noticed many of the library files seem to have an ending ?>. I'm struggling right now with a Views Feed which won't validate because of a single space at the start of the file. I'm not sure whether these libraries could cause that problem or not, but if so, it might be worth making sure there are no straggling, unsuspected spaces at the end of these files.

Log in or register to post comments

Comment #3

mikeytown2 commented 27 September 2011 at 20:45

Status	File	Size
new	advagg-1285886-3.patch	24.16 KB

I've committed this patch, leaving this issue open.

Created issues in the libraries various projects in regards to removing ?>
Left a message for JS Packer, CSS Tidy, and CSS Compressor. JSMin+ did not have this issue.
http://drupal.org/coding-standards#phptags