Posted by megensel on September 21, 2011 at 6:29pm
6 followers
Jump to:
| Project: | Drupal core |
| Version: | 8.x-dev |
| Component: | system.module |
| Category: | bug report |
| Priority: | minor |
| Assigned: | Unassigned |
| Status: | closed (fixed) |
| Issue tags: | needs backport to D7 |
Issue Summary
Also referencing Issues:
#820816: #type text_format not compatible with system_settings_form($automatic_defaults = TRUE)
and
#266246: Add smart defaults for system_settings_form
on line 1584 of systems.admin.inc, system_settings_form is being passed a second parameter when the api does not show support for it. After looking into the patches in the above listed issues I see this was fixed in other functions but looks like it was missed on system_cron_settings.
| Attachment | Size | Status | Test result | Operations |
|---|---|---|---|---|
| system_settings_form_incorrect_api_usage.patch | 474 bytes | Idle | PASSED: [[SimpleTest]]: [MySQL] 36,037 pass(es). | View details |
Comments
#1
Minor change, bots happy, im happy.
#2
Marking needs backport.
#3
This was missed when #266246: Add smart defaults for system_settings_form was reverted. I'm in favor.
#4
Restoring tag.
#5
Good catch. Committed to 7.x and 8.x. Thanks!
#6
Automatically closed -- issue fixed for 2 weeks with no activity.