Patch attached.

CommentFileSizeAuthor
#1 gigyUser_class.patch11.21 KBericduran

Comments

ericduran’s picture

ericduran commented
StatusFileSize
new gigyUser_class.patch11.21 KB
ericduran’s picture

ericduran commented
Status: Active » Needs review
apotek’s picture

apotek commented

Looks good, ericduran, but can you explicate the rationale of the code changes you made? What was the problem you are working around?

ericduran’s picture

ericduran commented

@apotek sure, Right now when ever the gigyaUser class is going to be used we need to make sure the gigya module is loaded which in turns loads more than it needs too.

This is excessive because drupal has a class auto-loader that can load any class when needed which requires a lot less effort. It'll also provide some separation between the class and the code.

gambaweb’s picture

gambaweb commented
Status: Needs review » Reviewed & tested by the community

thanks for that added

ericduran’s picture

ericduran commented
Status: Reviewed & tested by the community » Fixed

This was committed to the repo.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.