Hello, I am testing the latest dev version with an error doing the following:

1. Create a Taxonomy Vocab.
2. Add a Term to the Vocab in above.
3. Try to delete the above Term and get the following error message:

Notice: Undefined index: vid in domain_taxonomy_form_alter() (line 101 of C:\xampp\htdocs\sites\all\modules\1230710-7.x-1.x-c54f531\domain_taxonomy.module).
Warning: array_flip() [function.array-flip]: Can only flip STRING and INTEGER values! in DrupalDefaultEntityController->load() (line 178 of C:\xampp\htdocs\includes\entity.inc).
Warning: array_flip() [function.array-flip]: Can only flip STRING and INTEGER values! in DrupalDefaultEntityController->cacheGet() (line 354 of C:\xampp\htdocs\includes\entity.inc).
Notice: Trying to get property of non-object in domain_taxonomy_form_alter() (line 104 of C:\xampp\htdocs\sites\all\modules\1230710-7.x-1.x-c54f531\domain_taxonomy.module).

Thanks!

CommentFileSizeAuthor
#6 1286814-6.patch635 bytesVyoma

Comments

Tim Jones Toronto’s picture

Tim Jones Toronto commented
Priority: Major » Minor

If you disable Domain Taxonomy, you can delete it fine.

Tim Jones Toronto’s picture

Tim Jones Toronto commented
Priority: Minor » Major
Vyoma’s picture

Vyoma commented

Let me see if I can replicate this on my development box.

Update: I have been able to replicate this on my development box.

Vyoma’s picture

Vyoma commented
Assigned: Unassigned » Vyoma
Vyoma’s picture

Vyoma commented
Status: Active » Needs review

Got a quick fix for this.

Seems like it is trying to 'form_alter' for taxonomy editing forms, but when the term is being deleted, there is no vid (vocabulary id).

The fix is to skip the form_altering if 'vid' is not set.

Vyoma’s picture

Vyoma commented
StatusFileSize
new 1286814-6.patch635 bytes

Here is the patch attached. Pushed this to the sandbox project.

Please apply patch or checkout from sandbox, and let me know if this works as expected.

Tim Jones Toronto’s picture

Tim Jones Toronto commented

Patch works fine - thank you!

I am pushing this module to test multiple sites and is working very well so far. It even works using Taxonomy Menu – and drop down menu support e.g. Nice Menu on per-site basis. Very cool!

Thanks, Tim.

Vyoma’s picture

Vyoma commented
Status: Needs review » Fixed

Good - so the patch works.

I am trying to get co-maintainer access #1230706: Offering to co-maintain Domain Taxonomy so that I can push this to the "official" project as a branch.

Tim Jones Toronto’s picture

Tim Jones Toronto commented

Great. I would like to start promoting the D7 version over on Domain Access when you have this sorted out.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.