It would be nice if weather icons could change with the theme rather than they are the ones included or the ones in the second location.

If you have a dark and a light theme, you probably don't want the same set of weather icons for both.

Comments

SeanJA’s picture

Title: Weather icons per active theme » Weather icons per active theme patch
Status: Active » Needs review
StatusFileSize
new1.29 KB

I have attached a patch for this, it appears to work fine on local drupal install.

Status: Needs review » Needs work

The last submitted patch, weather_module_icons_per_theme.patch, failed testing.

SeanJA’s picture

StatusFileSize
new1.5 KB

I guess I did the patch wrong, this time I followed the directions on the "how to do it" page

SeanJA’s picture

Status: Needs work » Needs review
StatusFileSize
new1.5 KB

Try this again... with the right status

toddy’s picture

Version: 6.x-5.18 » 7.x-2.x-dev
Assigned: Unassigned » toddy
Status: Needs review » Patch (to be ported)

Hi,

sorry for the late reply. Thanks a lot for the patch, this is an interesting idea. I'm therefore bumping the version to 7.x-2.x.

Regards,
Tobias

ysamoylenko’s picture

Issue summary: View changes
StatusFileSize
new5.65 KB
new9.96 KB

Hello,
sorry for the late reply.

This functionality is already implemented in a newer version of the module.
Just put the weather images directory name to the override field, then place your images into that directory.

Then the image will be processed from the specified directory.

The output will look like on the screenshot.

Anyway, thanks for your efforts.

ysamoylenko’s picture

Status: Patch (to be ported) » Fixed
StatusFileSize
new15.83 KB
new13.77 KB

Also, you can use "Meteocons" Webfont instead of images.


Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.