here is the patch for this bug.

CommentFileSizeAuthor
nodewords-install1.patch898 byteshass

Comments

Robrecht Jacques’s picture

Robrecht Jacques commented

Can you explain me why this is needed?

I notice that the Drupal core tables (see modules/system/system.install) are currently installed without any Type=MyISAM or Type=InnoDB. Should I remove it completely?

Please provide me a link that the preferred MySQL table type in Drupal is InnoDB.

hass’s picture

hass commented

Simply install Drupal 5 from scratch. You will see all tables are Type=InnoDB.

Performance sites should use InnoDB...

Look here: http://drupal.org/node/51263?

hass’s picture

hass commented
Status: Needs review » Needs work

ups, you are right... system.install have no db type defined... then i think you should remove this completely and let the DB install the default engine. sound better... i wondered why you module created MyISAM and Drupal themself InnoDB on my MySQL 5.0.27. so this must be the default engine on my box.

lets removed the type...

Robrecht Jacques’s picture

Robrecht Jacques commented
Assigned: Unassigned » Robrecht Jacques

The reason MyISAM as type was used is just historically, this was the default in 4.6/4.7.

Do you think the nodewords_update_6() is still needed?

hass’s picture

hass commented

No nodewords_update_6() seems no more required then.

But we should have a look what happen on such a upgrade... maybe we should do a type change - i don't know for sure.

Robrecht Jacques’s picture

Robrecht Jacques commented
Assigned: Robrecht Jacques » Unassigned
Status: Needs work » Fixed

Fixed in 5.x-1.x-dev. The change will be included in the next stable release (5.x-1.3).

I've decided not to include the nodewords_update_6() (which changes the type of the database to InnoDb). New installs will get the default db table type, old installs either are low volume (in which case it's not that important to change the type) or high volume (in which case they know better then me what db table type they'll need).

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)