Closed (duplicate)
Project:
Dreditor (moved)
Version:
6.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
22 Sep 2011 at 16:53 UTC
Updated:
6 Aug 2013 at 20:13 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
sunHm. This might be a browser/platform-specific rendering/font-size issue.
If you happen to run across this issue once more, please post a link to the affected patch/comment, so we can double-check and debug.
Comment #2
tstoecklerI don't know if this is the same issue, but it seems related:
In the patch at http://drupal.org/node/1414314#comment-5512228 in the first hunk of path.admin.inc there is a comment, which according to Dreditor wraps early. It doesn't really, though.
I'm on FF9.0.1/Win7.
Comment #3
sunThis is what I see for the mentioned hunk in that patch:
Comment #4
sunThe actual code + 80 chars delimiter in ASCII:
| // Enable language column if language.module is enabled or if we have any | // alias with a language. | | // Enable language column if language.module is enabled or if we have any alia| |Does not wrap too early, and at least for me, identical view/result in patch reviewer.
Comment #5
tstoecklerWell, this is in fact a font-size issue. Apparently I'm viewing the browser larger than the rest of the world.
I attached screenshots of the same hunk in my
- my normal viewing size (which seems to be default +1)

- a smaller viewing size (~default)

- a larger viewing size (~default +2)

Comment #6
sunThat makes sense. Need to use relative units everywhere. (ugh, that's going to get a 5th point decimal digit thing...)
Comment #7
scor commentedI just RTBC'ed a patch which looked good on my dreditor but which in fact had docs going over the 80 chars limit: http://drupal.org/node/1089040#comment-5653258
This is how it looks, even after updating to the latest dreditor from the project page:
Update: and changing the font size on FF (Command + +/-) does not change anything.
Comment #8
sunApparently, the CSS uses em already. :(
We need a CSS expert who's smarter than me to figure out why the location of the delimiter changes on browser zooming, despite using a relative unit already.
Comment #9
markhalliwellFixed by #2026847: Make the dreditor file browser wide enough to be useful with PSR-0 paths and allow scrolling