Closed (fixed)
Project:
Views Bulk Operations (VBO)
Version:
6.x-1.11
Component:
Core
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
23 Sep 2011 at 17:15 UTC
Updated:
26 Oct 2011 at 17:30 UTC
Jump to comment: Most recent file
Comments
Comment #1
geneticdrift commentedComment #2
creeksideplayers commentedThe table headers also missing class information. All the table headers are coming up with a class of "views-field-v". This has broken the formatting on my site where I set the column widths based on the class names. I applied the patch, and I also made this change the "th" lines from this:
to this:
Comment #3
bojanz commented@geneticdrift @hsvmda
Which Views versions are you using?
I'm guessing something is wrong with the way VBO calls the template file, if $fields is undefined.
Might be something about Views 2 <> Views 3 (VBO tries to support both branches, which is generally a bad idea).
Comment #4
geneticdrift commentedUsing views version 6.x-2.12
Comment #5
creeksideplayers commented@bojanz - I'm using Views 6.x-2.12
Comment #6
todd nienkerk commentedI can also confirm this in Views 6.x-2.12.
Comment #7
ryan_courtnage commentedConfirmed - Views 6.x-2.12
Comment #8
ryan_courtnage commentedFYI, i don't think that the OP's patch is the right fix. In 6.x-1.10, the class for a row would have looked like (for example):
With the OP's patch, it will look like:
The bug is likely be in the preprocess function and not the tpl.
Comment #9
ryan_courtnage commentedI do believe that the attached is the correct fix for this issue. Basically, we need to build $vars['fields'] appropriately in the preprocess. As well, we need to apply the 'active' class to the column being sorted.
Can someone using Views 3 confirm if the VBO table classes are applied properly?
Comment #10
bojanz commentedryan_courtnage, you're a rock star :)
Confirmed that it works with Views 3. Committed. Thanks!
Comment #11
creeksideplayers commentedThanks, bojanz. That works a lot better, but there is still a problem with the table data for the select column:
I've added this to the for loop in views-bulk-operations-table.tpl.php that outputs the table data:
Comment #12
bojanz commentedI wasn't sure whether we needed a class there. But sure. Setting to "needs review" for now, and I'll take a look later.
Comment #13
bojanz commentedCommitted.