SchemaCache generates empty cid [#1289364]

Comment	File	Size	Author
#5	1289364-after.patch	1.51 KB	swentel
#2	1289364-before.patch	1009 bytes	swentel
#2	1289364-after.patch	1.5 KB	swentel
	empty_cid.patch	529 bytes	swentel
	empty-cid.png	25.73 KB	swentel

Comment #1

chx commented 23 September 2011 at 23:41

Well spotted! tests?

Log in or register to post comments

Comment #2

swentel commented 24 September 2011 at 00:22

Status	File	Size
new	1289364-after.patch	1.5 KB
new	1289364-before.patch	1009 bytes

Added a very simple test - the before patch will fail, the after should pass.
Should cache_set also do nothing if the $cid is empty ?

Log in or register to post comments

Comment #3

catch

he/him

English

commented 24 September 2011 at 06:46

Component:	cache system	» base system
Status:	Needs review	» Reviewed & tested by the community

Looks good, nice find!

Log in or register to post comments

Comment #4

dries commented 24 September 2011 at 19:13

Status:

Reviewed & tested by the community

» Fixed

Committed to 8.x. Thanks!

Log in or register to post comments

Comment #5

swentel commented 24 September 2011 at 19:21

Version:	8.x-dev	» 7.x-dev
Status:	Fixed	» Needs review

Status	File	Size
new	1289364-after.patch	1.51 KB

Here's the 7.x version.

Log in or register to post comments

Comment #6

24 September 2011 at 20:03

Status:

Needs review

» Needs work

The last submitted patch, 1289364-after.patch, failed testing.

Log in or register to post comments

Comment #7

swentel commented 24 September 2011 at 20:22

Status:

Needs work

» Needs review

Hmm, ok, I don't really see why this might trigger an exception there - just trying another review, maybe there's been a slight glitch - will ping one of the testbot maintainers afterwards (or I should try it out locally first maybe)