eBible Verselink Module

rtdean93, check out the article, Review process for Full Project Applications: What to Expect.

It's great that your module has been reviewed by others; that could help accelerate this process. I'd encourage them to post their reviews to this issue. Beyond the community at-large, a git administrator must ultimately validate the community's RTBC decision.

Again, please take a look at that article. There's a section that discusses timeline expectations. Reviewing others' projects, yourself, will help yours to be handled more quickly, and will also aid in demonstrate your own understanding of the process and requirements.

• please add a link to the eBible API on your project page
• git release branch missing, see http://drupal.org/node/1015226
• info file: "core = 7.x" doubled
• how does it work? What is the syntax to create a reference? What does the javascript do that you are loading?
• hook_init() is not ideal as it is executed on literally every page request, even if the page has nothing to do with your module or your module will not be needed there. It is possible to include javascript in the info file, but I guess that does not work for external javascript http://drupal.org/node/756722 . So probably it is ok to use hook_init here.

There are still files other than README.txt in the master branch, make sure to remove them. See also step 5 in http://drupal.org/node/1127732
Review of the 7.x-1.x branch:

• Drupal Code Sniffer has found some code style issues (please check the Drupal coding standards). See attachment.

This automated report was generated with PAReview.sh, your friendly project application review script. Go and review some other project applications, so we can get back to yours sooner.

manual review:

• This module is too short to approve you as git vetted user. We are currently discussing how much code we need, but everything with less than 120 lines of code cannot be seriously reviewed. However, we can promote this single project manually to a full project if you wish. Please fix the remaining issues first.

Unless I've misunderstood this module, it is very similar to the Scripture Filter module (which I maintain). The latter currently links by default to biblegateway.com.

It would be preferable to modify Scripture Filter so that there is an option to link to ebible.com, than to have a second module that duplicates its functionality except for using a different Bible-text website.

Out of interest, what is the distinctive contribution of eBible.com; when would a site owner want to link to that, and when would a site owner want to link to biblegateway.com? I'd like to understand the relative advantages of eBible.com as a site to link to.

This application has been marked as 'needs work' for 19 weeks, and there are no contact form to rtdean93 on drupal.org, so I am closing this one.

@rtdean93, if is this is wrong, please reopen the application.

Added demo site - still needs review in order to move from Sandbox to Mods page