weblink_user uses invalid (old?) $type definitions:

function weblink_user($type, &$edit, &$user) {
  if (variable_get('weblink_target_user', 0)) {
    switch ($type) {
      case "register_form":
        return form_hidden("weblink_new", variable_get('weblink_target_default'));
      case "edit_form":
        return array(t("Weblink settings") => form_select(t("Open new window for weblinks"), "weblink_new", $user->weblink_new, array(t("Disabled"), t("Enabled")), t("Create a new window when you click on a weblink.")));
     case "form":
           return array(array('title' => t('Weblink settings'), 'data' => form_select(t("Open new window for weblinks"), "weblink_new", $user->weblink_new,  array(t("Disabled"), t("Enabled")), t("Create a new window when you click on a weblink.")), 'weight' => 5)); 
     break; 
    }
  }

To get user menu working:

function weblink_user($type, &$edit, &$user) {
  if (variable_get('weblink_target_user', 0)) {
    switch ($type) {
     case "form":
           return array(array('title' => t('Weblink settings'), 'data' => form_select(t("Open new window for weblinks"), "weblink_new", $user->weblink_new, array(t("Disabled"), t("Enabled")), t("Create a new window when you click on a weblink.")), 'weight' => 5)); 
     break; 
    }
  }
}

I have no idea what "register_form" has been translated into.

Comments

Anonymous’s picture

(not verified) commented

Should be Version 4.5.0

Bèr Kessels’s picture

Bèr Kessels commented

I am going to make a general directory.module, one that will replace the weblink browsing functionality.

Anonymous’s picture

(not verified) commented

Is there a time line for the directory.module?
Not to pester you about it, but I'm working on a "medialinks" module and will abandon it if the general directory module will be along soon...

I assume a general directory will allow any (or all) nodes to be presented in a directory view? So then weblinks becomes a node type, rather then the whole system? Which would mean I would just have to create a media node type?

Thanks for all the hard work Ber!

Bèr Kessels’s picture

Bèr Kessels commented

> Is there a time line for the directory.module?
No. but it wont be weeks away.

>Not to pester you about it, but I'm working on a "medialinks" module
>and will abandon it if the general directory module will be along
>soon...
It sounds like you should not make this module, but rather use flexinode.

> So then weblinks becomes a node type, rather then the whole system?
I will probably drop the whole weblink node type in favor of flexinode.

Anonymous’s picture

(not verified) commented

>It sounds like you should not make this module, but rather use flexinode.

The medialinks bit I've done is a direct hack of weblinks with an amazon search interface in order to add items.
I will drop it now and fiddle with flexinode...

I discarded flexinode initially because I could find no information on extending them beyond the node type...
ie, can I create a custom way to add a flexinode?
The flexinode\contrib stuff seems like a start towards this, but it is unclear.

For example, say I have a "weblink" style flexinode (probably url, since it exists).. how do I create a system to monitor specific links?
A monitor.module will likely be overkill (since you are creating a module to address a single type of flexinode) but is certainly the easiest method, unless I am missing something.

Generally, flexinode seems young, and likely to change considerably before it is integrated to core...
This means any work I do using it will likely have to be revised to keep up with changes.. this is work I am not looking for...

(pardon my rant for a minute... sometimes you just have to vent)
*sigh* I’ve tried to use Drupal for three different projects, and each time I've run into problems where a set of features is not mature enough to defend... I thought this time might be different...

I love this system... it is by far the simplest, most flexible and most elegant system I have found.. and I understand the creation process necessarily breaks things as it moves forward... but the lack of clear and evolving end-user documentation makes it difficult to follow where development is headed and what features people should expect to see change.
(end rant)

Bèr Kessels’s picture

Bèr Kessels commented
Status: Postponed » Closed (won't fix)

Weblinks is superceded by http://drupal.org/project/links. That module even has an upgrade path from weblinks.