Needs work
Project:
Google Fonts
Version:
6.x-2.0-beta3
Component:
Code
Priority:
Critical
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
24 Sep 2011 at 20:12 UTC
Updated:
26 May 2013 at 08:37 UTC
Jump to comment: Most recent file
Comments
Comment #1
mrfelton commentedAttached patch seems to resolve. Note, I also removed the _google_fonts_system_fontname function as it was unused.
- Tom
Comment #2
mrfelton commentedNot sure why the previous patch wouldn't apply from a drush make file.
Comment #3
mrfelton commentedComment #4
mrfelton commentedSorry about this, not sure what's going on.
Comment #5
recidive commentedShouldn't _google_fonts_family_array_key_dencode() be changed as well? Otherwise this is RTBC.
Bumping to critical as this makes half of the fonts unusable.
Comment #6
BarisW commentedThanks, I'll look into it. However, you might want to switch to @font-your-face. As stated on the module page, I've decided to put my efforts in the FYF module instead of the Google Fonts module. The FYF module also supports Google Fonts, as well as many others.
Comment #7
BarisW commentedTom,
I checked your patch but this does not seem to be an issue. The module already replaces spaces with a + sign, in
<code>_google_fonts_family_pathname(). If you check the call to the CSS file, you'l see that the request points to (example)http://fonts.googleapis.com/css?family=Covered+By+Your+Grace&subset=latinDoes the current code fails in your configuration? Could you please clarify what the URL is of the CSS file that is requested?
Comment #8
sbgoldi commentedChange in google_fonts.module
line 153:
function _google_fonts_family_array_key_encode($string) {
return str_replace(' ', '_', $string);
}
to
function _google_fonts_family_array_key_encode($string) {
return str_replace(' ', '+', $string);
}
Comment #9
meladawy commentedI got it to work by replacing line 85
with