Dev Version works well

WRXIzumi - March 19, 2007 - 02:42
Project:Active Select
Version:5.x-1.x-dev
Component:Code
Category:bug report
Priority:normal
Assigned:Unassigned
Status:closed
Description

The attached patch has resolved the issue of having a blank target select list in IE. Tested with FF 2.0.0.1 under Linux and 1.5.9 and 1.5.10 under WinXP. As well as IE 6 and 7 under WinXP. I needed this so I could use the content_taxonomy_activeselect fields in IE.

To give due credit, this work was sponsored by leftrightminds.com.

AttachmentSize
activeselect.patch1.3 KB

#1

bdragon - April 8, 2007 - 04:49
Status:patch (reviewed & tested by the community)» fixed

Modified patch committed to DRUPAL-5 and HEAD.

http://drupal.org/cvs?commit=63386
http://drupal.org/cvs?commit=63387

Pushing it works on all browsers, right? Seemed like a simpler solution.

Please reopen if my changes to your patch broke anything.

Thanks,
--Brandon

#2

knseibert - April 9, 2007 - 13:49
Status:fixed» active

Hi Brandon,
i've installed the latest cvs version for Drupal 5.1. Firefox works great under XP SP2. Opera and IE7 fail. Both remain blank.

#3

knseibert - April 9, 2007 - 14:06

Here's the Opera error log:
JavaScript - http://domain/node/add/page
Unknown thread
Error:
name: TypeError
message: Statement on line 152: Type mismatch (usually a non-object value used where an object is required)
Backtrace:
Line 152 of linked script http://domain/sites/all/modules/activeselect/activeselect.js
this.targets[targetIndex].options.push(new Option(text, value, false, selected));
Line 246 of linked script http://domain/sites/all/modules/activeselect/activeselect.js
db.owner.populate(targets);
Line 1 of eval script
if (xml && (xml.readyState == 4 || isTimeout == "timeout"))
At unknown location
[statement source code not available]

#4

bdragon - April 9, 2007 - 14:40

OK, rolling back to the 4.7 version of the line, which accomplishes the same thing as the patch without using a temporary variable.

#5

GLHMarmot - April 20, 2007 - 22:19
Title:Fix for blank select list in IE» Dev Version works well
Status:active» fixed

Thanks for applying a version of the patch. Or at least rolling back to a version that had the same effect. I can confirm that the Apr 9, 2007 development version of this module now works great with content_taxonomy under Firefox and IE 6. (I did not test with IE 7 but expect the same result.)

As far as I am concerned this bug report can be closed.

#6

Anonymous - May 4, 2007 - 22:31
Status:fixed» closed

#7

Onopoc - March 9, 2008 - 07:11

The following works for me:

Change line 156 (approx) from activeselect.js

-- $(this.targets[targetIndex]).append(new Option(text, value, false, selected));

++ if (navigator.appName == "Microsoft Internet Explorer") {
++ this.targets[targetIndex].add(new Option(text, value, false, selected));
++ }else{
++ $(this.targets[targetIndex]).append(new Option(text, value, false, selected));
++ }

Thanks to olemsa: http://drupal.org/node/147076#comment-561190

 
 

Drupal is a registered trademark of Dries Buytaert.