no modern browsers use khtml engine ??

(only 2 theme & 1 module in CORE supporting -khtml now..we have to patch others if it needed.)

Comments

tim.plunkett’s picture

We could take this opportunity to replace them with -o- for Opera...

robloach’s picture

It's Konqueror. Good luck getting this patch by Crell :-) .

aspilicious’s picture

@tim.plunkett, not needed, they work without the prefix

http://dev.opera.com/articles/view/css3-border-background-boxshadow/#bor...

droplet’s picture

StatusFileSize
new5.58 KB

we dropped IE6, and going to drop IE7 and wedkit 3,4.. but supporting Konqueror which only less than 1% usage ?? it's like a mistake. I think we can dropped D7 -khtml-prefix supports as well.

my patch below modified 3 files, but those 10+ files contain border-radius stuff without -khtml-prefix:
(border-radius just an example, there're more prefix stuff in D7)

core/misc/ui/jquery.ui.theme.css
core/modules/block/block.admin.css
core/modules/contextual/contextual-rtl.css
core/modules/contextual/contextual.css
core/modules/dashboard/dashboard.css
core/modules/overlay/overlay-child-rtl.css
core/modules/overlay/overlay-child.css
core/modules/shortcut/shortcut-rtl.css
core/modules/shortcut/shortcut.css
core/modules/simpletest/files/css_test_files/css_input_without_import.css
core/modules/simpletest/files/css_test_files/css_input_without_import.css.optimized.css
core/modules/simpletest/files/css_test_files/css_input_without_import.css.unoptimized.css
core/modules/system/system.theme.css
core/modules/toolbar/toolbar.css
core/themes/bartik/color/preview.css
core/themes/bartik/css/style.css
core/themes/seven/jquery.ui.theme.css
core/themes/seven/style.css

also: #1290506: Remove webkit-specific border radius from CSS

catch’s picture

This article suggests that Konqueror 1. added support for webkit 2. may drop khtml at some point (or at least no longer require the prefix) -however I couldn't find any detail about this at all either on konqueror's site or random googling.

http://digitizor.com/2010/08/11/how-to-switch-to-webkit-in-konqueror-bro...

aspilicious’s picture

Status: Needs review » Reviewed & tested by the community

And WHY should we support a browser like konquer. Can we support Lynx while we are on it? *sigh*

This is rtbc...

(btw, we don't use the khtml prefix in core in every place so it looks crap anyway at this moment)

robloach’s picture

Issue tags: +Less code

Don't be disrespecting Konqueror! To my knowledge, Webkit was a fork of KHTML back in the day ;-) . RTBC++.... Going to start using the Less Code tag more too haha.

jacine’s picture

cool :)

dries’s picture

Just for the record; I'm also in favor of this patch. I plan to commit it shortly.

catch’s picture

Status: Reviewed & tested by the community » Fixed

Looks like Dries didn't get back to this. I've gone ahead and committed/pushed to 8.x.

droplet’s picture

Thanks.

Needs to backport it ? or patch other D7 modules to support it ? or leave it as now :) I think supports -khtml-prefix isn't the original ideas during D7 development.

catch’s picture

Hmm. I doubt webchick would want to remove this in D7 since if you are using Konqueror it'd be a regression - maybe an issue to fix it in D7 though?

droplet’s picture

Version: 8.x-dev » 7.x-dev
Status: Fixed » Needs review
Issue tags: +Needs backport to D7
StatusFileSize
new5.52 KB
webchick’s picture

Version: 7.x-dev » 8.x-dev
Status: Needs review » Fixed

Yeah, sorry. D7 shipped with Konqueror support so I don't think it's a good idea to drop it arbitrarily in a stable point release. Moving back to 8.x and fixed.

We should probably make a change notice about this. droplet, could you do the honours? :)

droplet’s picture

Automatically closed -- issue fixed for 2 weeks with no activity.