Closed (fixed)
Project:
Drupal core
Version:
7.x-dev
Component:
CSS
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
25 Sep 2011 at 23:50 UTC
Updated:
4 Jan 2014 at 01:11 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
bleen commentedThe patch in the original post was empt (0k) so I'm using this issue to show someone how to create & submit a patch to D.O.
Here we go.
Comment #2
droplet commentedOh, didn't notice it, sound like drupal.org problem. I seem another 0 byte patch and created an issue #1290674: Don't test 0 bytes patch.
Thank @bleen18. can I mark it RTBC ?
Comment #3
bleen commenteddroplet, if you have tested that the patch applies and youve double checked that there are no adverse effects, I think its safe for this to be marked RTBC... generally though the person who writes the patch is not supposed to be the one who marks it RTBC but since technically your patch was never posted... feel free.
Comment #4
devin carlson commentedJust adding a second +1.
bleen18's patch looks good; I checked this over yesterday but didn't RTBC it due to the 0 byte patch.
Comment #5
jacineFYI, We've got an issue for cleaning up every single module's CSS, with a plan for what we want to do with them here:
http://drupal.org/node/1089868
In the future, if you could please use them that would be great. Thanks.
Comment #6
sunNot really related to the "global CSS clean-up and separation" effort; looks ready to fly for me.
Comment #7
catchCommitted to 8.x. I'd not spotted this was tagged for backport but it looks fine there too.
Comment #8
jacine@sun Had there already been a patch in that issue, this would be addressed as part of it and there would be duplicate work going on. It's just a note for future reference though... I didn't change the status and agree this is ready.
Comment #9
jacineComment #10
webchickCommitted and pushed to 7.x. Thanks!