Posted by droplet on September 25, 2011 at 11:50pm
8 followers
| Project: | Drupal core |
| Version: | 7.x-dev |
| Component: | CSS |
| Category: | bug report |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | closed (fixed) |
| Issue tags: | needs backport to D7, Novice, Quick fix |
Issue Summary
a.contextual-links-trigger:hover,
div.contextual-links-active a.contextual-links-trigger {
background-position: 2px -18px;
}
div.contextual-links-active a.contextual-links-trigger {
background-position: 2px -18px;
background-color: #fff;
border-color: #ccc;
border-bottom: none;
position: relative;
z-index: 1;
-moz-border-radius: 4px 4px 0 0;
-webkit-border-bottom-left-radius: 0;
-webkit-border-bottom-right-radius: 0;
border-radius: 4px 4px 0 0;
}No needs to redefine it.
| Attachment | Size | Status | Test result | Operations |
|---|---|---|---|---|
| context.patch | 0 bytes | Idle | PASSED: [[SimpleTest]]: [MySQL] 33,060 pass(es). | View details |
Comments
#1
The patch in the original post was empt (0k) so I'm using this issue to show someone how to create & submit a patch to D.O.
Here we go.
#2
Oh, didn't notice it, sound like drupal.org problem. I seem another 0 byte patch and created an issue #1290674: Don't test 0 bytes patch.
Thank @bleen18. can I mark it RTBC ?
#3
droplet, if you have tested that the patch applies and youve double checked that there are no adverse effects, I think its safe for this to be marked RTBC... generally though the person who writes the patch is not supposed to be the one who marks it RTBC but since technically your patch was never posted... feel free.
#4
Just adding a second +1.
bleen18's patch looks good; I checked this over yesterday but didn't RTBC it due to the 0 byte patch.
#5
FYI, We've got an issue for cleaning up every single module's CSS, with a plan for what we want to do with them here:
http://drupal.org/node/1089868
In the future, if you could please use them that would be great. Thanks.
#6
Not really related to the "global CSS clean-up and separation" effort; looks ready to fly for me.
#7
Committed to 8.x. I'd not spotted this was tagged for backport but it looks fine there too.
#8
@sun Had there already been a patch in that issue, this would be addressed as part of it and there would be duplicate work going on. It's just a note for future reference though... I didn't change the status and agree this is ready.
#9
#10
Committed and pushed to 7.x. Thanks!
#11
Automatically closed -- issue fixed for 2 weeks with no activity.