Sometimes vertical ticker just wrap mask&container around the ticker multiple times so here is the patch (not much of coding done here) for the vertical ticker that fix that problem.

CommentFileSizeAuthor
#3 1290818-ticker-wrapping-and-timing-3.patch1.33 KBandrewbelcher
vertical_ticket_wrapping_ntimes_mask_and_container.patch814 byteshitriprsti

Comments

kmonty’s picture

kmonty
He/Him
Location Berlin, DE + SF, CA
commented
Priority: Normal » Critical
Status: Patch (to be ported) » Reviewed & tested by the community

Confirming the bug exists and this patch fixes the issue.

mwm’s picture

mwm commented

I ran into this same problem on 6.x-2.x-dev with a horizontal ticker. It works fine for logged-in users, but anonymous users get the mask and container twice. I tried this patch but it just caused the Javascript to never load, breaking the ticker completely. I don't understand the code well enough to debug it any further.

andrewbelcher’s picture

andrewbelcher commented
Status: Reviewed & tested by the community » Needs review
StatusFileSize
new 1290818-ticker-wrapping-and-timing-3.patch1.33 KB

@hitriprsti - thanks for that, saved me loads of time!

There was a similar bug for vTicker (as opposed to liScroll).

I've not looked closely at the face/bbc to see if they also have a similar problem as I don't use them...

I've made a patch including your fix and also the fix for vTicker. Hopefully the maintainers can get it committed!

sgdev’s picture

sgdev commented
Issue summary: View changes
Related issues: +#2704723: Refactor module

Has been a while since this issue was posted, although there have been others about this particular issue and other patches made.

The primary problem is the use of inline JavaScript. Doing so causes lots of problems when interacting with other JavaScript on a Drupal site.

Please review the patch we created that fixes all of these problems, and also adds new features: https://www.drupal.org/node/2704723

Thanks.

nwom’s picture

nwom commented
Status: Needs review » Closed (duplicate)

Can be fixed with the patch on #2704723: Refactor module