Semantics request
| Project: | Shoutbox |
| Version: | 5.x-1.x-dev |
| Component: | Code |
| Category: | feature request |
| Priority: | normal |
| Assigned: | disterics |
| Status: | closed |
Jump to:
When trying to style the Shoutbox module I encountered a few things that weren't so semantic as I'd hoped. For every post there are a few buttons to perform actions on that post: delete, edit, etc. I suggest making ordinary links of them instead of using image tags directly in the links. Image tags are to add images which are part of the content. I don't think these images are, so It's better to make textual links and style them with CSS so the text's gone and the images are shown.
I've also got something else. Drupal uses the classes 'odd' and 'even' for posts while the Shoutbox module uses 'shoutbox-row0' and 'shoutbox-row1'. I would change these classes repectively to 'shoutbox-row odd' and 'shoutbox-row even'. This makes things a bit more consistent and you separate two different classes from eachother ('shoutbox-row0' is in fact two classes. One indicates it's a shoutbox row and the other ('0') says it's an odd row).
Hope I've explained my thoughts well enough :-)
#1
Xano,
WRT: Images
I think understand what you are saying. Can you give me patch for the css that will enable this feature ?
WRT: row0 and row1
I fixed this in 5.x-dev and HEAD
Thank you
#2
I wouldn't know how to make patch files, I know you'll need a commandline to execute them and if that's what you need for creating them I can't do that (Windows-only over here because Photoshop doesn't run under Linux :-P ). What I can do is make some new code and post it here so you can easily change the old files.
#3
Yeah,
basically just paste the css that will convert the link to images.
Thanks
#4
#5
#6
Automatically closed -- issue fixed for 2 weeks with no activity.