I would like to add support for HTTP header if-modified-since as a parameter source for services callbacks.

CommentFileSizeAuthor
#6 add_if_modified_since-1291086-6-D6.patch1.06 KBpdrake
#4 add_if_modified_since-1291086-4.patch1.1 KBpdrake
#3 add_if_modified_since-1291086-3-D6.patch1.04 KBpdrake
#1 add_if_modified_since-1291086-1-D6.patch1.06 KBpdrake

Comments

pdrake’s picture

pdrake commented
StatusFileSize
new add_if_modified_since-1291086-1-D6.patch1.06 KB

The attached patch adds initial support for if-modified-since, which may be assigned in a services definition as shown below:

  array(
    'name' => 'modified',
    'optional' => TRUE,
    'type' => 'string',
    'description' => 'Return only objects updated since the supplied if-modified-since header date/time.',
    'default value' => NULL,
    'source' => array('headers' => 'IF_MODIFIED_SINCE'),
  ),
kylebrowning’s picture

kylebrowning commented
Category: feature » task

Im good with this but patch doesn't apply, can we get a re-roll and see a 7.x version?

pdrake’s picture

pdrake commented
Status: Active » Needs review
StatusFileSize
new add_if_modified_since-1291086-3-D6.patch1.04 KB

Here's an updated patch for 6.x-3.x.

pdrake’s picture

pdrake commented
StatusFileSize
new add_if_modified_since-1291086-4.patch1.1 KB

Here's a patch for 7.x-3.x.

kylebrowning’s picture

kylebrowning commented
Status: Needs review » Reviewed & tested by the community

Thanks!

pdrake’s picture

pdrake commented
StatusFileSize
new add_if_modified_since-1291086-6-D6.patch1.06 KB

Attached is a patch for 6.x-3.1 for anyone who may be using that release since the above 6.x-3.x patch will not apply cleaning.

marcingy’s picture

marcingy commented
Version: 6.x-3.x-dev » 7.x-3.1

Moving to 7.x as it will be committed there first.

marcingy’s picture

marcingy commented
Status: Reviewed & tested by the community » Fixed

Committed, thanks

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.