Project:Slideshow
Version:master
Component:Code
Category:bug report
Priority:critical
Assigned:Unassigned
Status:closed (fixed)

Issue Summary

If you have two files with the same file names on your website, slideshow can link to the wrong file. While upload.module renames the file to not cause a conflict, slideshow.module doesn't reflect that change in its table.

Comments

#1

Priority:normal» critical

Any follow up on this? This is uite a problem as I have a lot of users on my site and the chance that two of them may use the same file name is very high.
I wonder: with the Token module is enable... would it be possible to have slideshow/%username instead of slideshow for the destination folder...
Many thanks,
Drupalworld.

#2

Subscribe

#3

This has already happened to me, users named files 1.jpg 2.jpg and slideshow did not show the right images.

The dev module shows this information:

Array
(
    [397] => stdClass Object
        (
            [fid] => 397
            [nid] => 78
            [filename] => 54_1.jpg
            [filepath] => sites/default/files/54_1_1.jpg
            [filemime] => image/jpeg
            [filesize] => 142010
            [vid] => 78
            [description] => 54_1.jpg
            [list] => 1
        )

    [398] => stdClass Object
        (
            [fid] => 398
            [nid] => 78
            [filename] => 54_1.jpg
            [filepath] => sites/default/files/54_1_2.jpg
            [filemime] => image/jpeg
            [filesize] => 42813
            [vid] => 78
            [description] => 54_1.jpg
            [list] => 1
        )

)

and

Array
(
    [body] => Array
        (
            [#value] => <p>pokus</p>

            [#weight] => 0
        )

    [slideshow] => Array
        (
            [#type] => slideshow
            [#attributes] => Array
                (
                    [class] => slideshow align-full location-above
                    [id] => slideshow-78
                )

            [#slideshow] => Array
                (
                    [settings] => Array
                        (
                            [slideshow-78] => Array
                                (
                                    [images] => Array
                                        (
                                            [1] => Array
                                                (
                                                    [src] => http://www.typosemestr.cz/system/files/slideshow/54_1.jpg
                                                    [title] => 54_1.jpg
                                                )

                                            [2] => Array
                                                (
                                                    [src] => http://www.typosemestr.cz/system/files/slideshow/54_1.jpg
                                                    [title] => 54_1.jpg
                                                )

                                        )

                                    [total] => 2
                                    [current] => 1
                                )

                        )

                    [status] => Array
                        (
                            [current] => 1
                            [total] => 2
                            [previous] => 2
                            [next] => 2
                        )

                    [url] => node/78
                    [title] => 54_1.jpg
                    [image] => http://www.typosemestr.cz/system/files/slideshow/54_1.jpg
                )

            [#weight] => -5
        )

)

As you can see, the upload does fine, renames the files (but, alas, not the descriptions), but the slideshow module picks up only the first image and shows it twice....

Roman

#4

Anybody willing to try to fix this bug... can pay some money...
I really like this module, but this bug makes it difficult to use on sites with many users... some for sure will use the same filename.
Currently the only way that I have is to tell my users to rename the file, and then rename the description... not so user friendly I am afraid...
Thanks

#5

Ive got the same issue.
This is a hell of a problem, please fix this as soon as possible!

#6

Status:active» fixed

This has been fixed in the most recent development version.

#7

Status:fixed» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

nobody click here