Co-maintainer

hi Spleshka,

Your contributions would be more than welcome! I have virtually no time anymore to invest in maintenance, let alone upgrading the module to D7.
I'm seeing forward to see your patches!
You appear to maintain some modules and themes already, so I assume you are familiar with git and the Drupal contribution workflow?

for your convenience, I already made a 7.x-1.x git branch

good luck!

Patch looks good but there's some minor issues with code-style and a bit of questions

http://drupal.org/coding-standards are changed from D6 times

+++ b/ascii_art_captcha/ascii_art_captcha.admin.incundefined
@@ -22,27 +27,27 @@ function ascii_art_captcha_settings_form() {
-    '#default_value' => variable_get('ascii_art_captcha_font_size', 0),
+    '#default_value' => (int) variable_get('ascii_art_captcha_font_size', 0),

(int) useless here

+++ b/ascii_art_captcha/ascii_art_captcha.infoundefined
@@ -1,5 +1,11 @@
+files[] = ascii_art_captcha.admin.inc
+files[] = ascii_art_captcha.install
+files[] = ascii_art_captcha.module

Only files that contains definitions of classes & interfaces should be listed here

+++ b/ascii_art_captcha/ascii_art_captcha.installundefined
@@ -1,7 +1,13 @@
+ * Implementation of hook_uninstall().

Drupal 7 style: Implements hook_hookname().

Try coder module review

+++ b/ascii_art_captcha/ascii_art_captcha.moduleundefined
@@ -48,9 +48,9 @@ function _ascii_art_captcha_get_allowed_characters() {
- * Implementation of hook_captcha
+ * Implementation of hook_captcha().

Implements!

+++ b/ascii_art_captcha/ascii_art_captcha.moduleundefined
@@ -48,9 +48,9 @@ function _ascii_art_captcha_get_allowed_characters() {
-function ascii_art_captcha_captcha($op, $captcha_type='', $response='') {
+function ascii_art_captcha_captcha($op, $captcha_type = '') {

$response variable been lost or unusable?

Great!

Cool,

I've notices most things in your patch are actually tweaks that also apply to the Drupal 6 code, so I applied it separately (both on 6.x-1.x and 7.x.1.x branch):
http://drupalcode.org/project/captcha_pack.git/commitdiff/3a2452f31777b4...

And kept the pure Drupal 7 port bits to the 7.x-1.x branch:
http://drupalcode.org/project/captcha_pack.git/commitdiff/8ea3e029970f3f...

@Spleshka: I also added write permissions for you to the git repo, so normally you should be able to push now

good luck

Please make a 7.x-1.x-dev release to invite more testers to the module

Cool!

I've just made a 7.x-1.x-dev snapshot and a 7.x-1.0-alpha1 release.

I think we can close this issue now, an wait for testers ... :)