Closed (fixed)
Project:
Mollom
Version:
7.x-2.x-dev
Component:
User interface
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
26 Sep 2011 at 17:34 UTC
Updated:
24 Apr 2014 at 17:13 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
sunComment #2
sun#1: mollom.status-report-api-key.1.patch queued for re-testing.
Comment #3
dries commentedThat looks like unnecessary clutter to me. It doesn't mean anything to a person that did not install Mollom, or to any non-technical person. Note that most people don't know what "API" means, nor should they.
Comment #4
sunI can get behind your thinking, but I think you're applying the wrong target audience to this page.
Almost all other output on this page wouldn't mean anything to me if I hadn't installed Drupal or was a non-technical person. Do you think that "GD library", "PHP memory limit", or "Unicode library" means anything to the casual user? :)
Second, there is a "Mollom API key" row in the status report already in case the API keys are not configured or invalid. That is, because we need and want to participate in Drupal's requirements checks, so site administrators are automatically informed about an incomplete or bogus configuration whenever that is the case.
This patch merely tweaks Mollom's requirements check to output the row permanently and not only on an error. I could see this being helpful for support tickets, for which we usually ask the users to check their status report page to confirm that it doesn't report any errors. Most often, we're asking for the user's public key in the same ticket reply.
If you're merely concerned about the "API" wording, we could rename it to "Mollom consumer key" or "Mollom client key".
(both of the latter terminologies are actually derived from the OAuth standard)
Comment #5
sunI still think this is ready to be committed.
Comment #6
sunCommitted with minor adjustment to 2.x branches.