As of now, the module only outputs a requirements error if the API keys are invalid or could not be verified.

When keys are correct and verified, and the module is able to work, there is no output on the status report page.

Let's also output something in the positive case. Would be nice to directly see the public key there.

Comments

sun’s picture

Status: Active » Needs review
StatusFileSize
new11.61 KB
new1.14 KB

mollom.status-report-api-key.1..png

sun’s picture

dries’s picture

That looks like unnecessary clutter to me. It doesn't mean anything to a person that did not install Mollom, or to any non-technical person. Note that most people don't know what "API" means, nor should they.

sun’s picture

I can get behind your thinking, but I think you're applying the wrong target audience to this page.

Almost all other output on this page wouldn't mean anything to me if I hadn't installed Drupal or was a non-technical person. Do you think that "GD library", "PHP memory limit", or "Unicode library" means anything to the casual user? :)

Second, there is a "Mollom API key" row in the status report already in case the API keys are not configured or invalid. That is, because we need and want to participate in Drupal's requirements checks, so site administrators are automatically informed about an incomplete or bogus configuration whenever that is the case.

This patch merely tweaks Mollom's requirements check to output the row permanently and not only on an error. I could see this being helpful for support tickets, for which we usually ask the users to check their status report page to confirm that it doesn't report any errors. Most often, we're asking for the user's public key in the same ticket reply.

If you're merely concerned about the "API" wording, we could rename it to "Mollom consumer key" or "Mollom client key".

(both of the latter terminologies are actually derived from the OAuth standard)

sun’s picture

Status: Needs review » Reviewed & tested by the community

I still think this is ready to be committed.

sun’s picture

Status: Reviewed & tested by the community » Fixed
StatusFileSize
new1.19 KB

Committed with minor adjustment to 2.x branches.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

  • Commit 8918fa9 on 7.x-2.x, 8.x-2.x, fbajs, actions by sun:
    - #1291310 by sun: Output public key on Status report page.
    
    

  • Commit 8918fa9 on 7.x-2.x, 8.x-2.x, fbajs, actions by sun:
    - #1291310 by sun: Output public key on Status report page.