Notice: Uninitialized string offset: 0 in _nodeformsettings_settings_form() (line 87 of siteroo /example.com/sites/all/modules/nodeformsettings-7.x-2.x-dev/nodeformsettings/includes/settings_node.inc).
Notice: Uninitialized string offset: 0 in _nodeformsettings_settings_form() (line 97 of siteroot/example.com/sites/all/modules/nodeformsettings-7.x-2.x-dev/nodeformsettings/includes/settings_node.inc).
Why this?
version D 7.8

CommentFileSizeAuthor
#2 nodeformsettings-1291772.patch1.75 KBalexweber

Comments

alexweber’s picture

alexweber commented

I am getting the exact same notices on Drupal 7.10 & Nodeformsettings 7.x-2.x-dev latest release.

Should be simple enough to fix.

alexweber’s picture

alexweber commented
Status: Active » Needs review
StatusFileSize
new nodeformsettings-1291772.patch1.75 KB

Patch attached, in both lines 87 and 97 of setings_node.inc an extra isset() is needed to check whether the array key exists.

Shadlington’s picture

Shadlington commented

Patch works for me.

alexweber’s picture

alexweber commented

Can we get a RTBC?

trgreen17’s picture

trgreen17 commented

Same exact error here. D7 and 7.x-2.x-dev of Node Form Settings. Thanks for a great module but is there any chance of getting this very old issue fixed without a patch?

alexweber’s picture

alexweber commented

@trgreen23 the patch attached in #2 works (or worked at the time), just a matter of testing it out and setting to RTBC for one of the maintainers to take a look at it if it still works

trgreen17’s picture

trgreen17 commented

@alexweber: Thank you very much. The patch seems to be working.

Tim

alexweber’s picture

alexweber commented

RTBC?

maximpodorov’s picture

maximpodorov commented
Status: Needs review » Reviewed & tested by the community

The patch solves the problem.

kssundar’s picture

kssundar commented
Issue summary: View changes
Status: Reviewed & tested by the community » Patch (to be ported)

This patch is still not ported to the latest 7.x branch

  • ram4nd committed a9b9979 on 7.x-2.x authored by alexweber 
    Issue #1291772 by alexweber: I am getting this server notice Notice
ram4nd’s picture

ram4nd commented
Status: Patch (to be ported) » Fixed
kssundar’s picture

kssundar commented
Status: Fixed » Closed (fixed)