Download & Extend
Email Registration » Issues

Keep the email login entered by the user so it can be validated

Posted by pcambra on September 27, 2011 at 7:35am
Project:Email Registration
Version:6.x-1.x-dev
Component:Code
Category:task
Priority:normal
Assigned:Unassigned
Status:closed (fixed)

Issue Summary

Hi

In some use cases (as mine now) you want to validate that the mail entered in login form is ok and you want to force login only by email, this can be accomplished just with a custom validate handler that validates the email but email_registration doesn't keep this data.
I'm attaching a really little patch for keeping the email address in the validation phase.

Login or register to post comments

Comments

#1

Posted by pcambra on September 27, 2011 at 7:43am
Status:active» needs review
AttachmentSizeStatusTest resultOperations
1291908-keep_email_for_validate-1.patch720 bytesIdlePASSED: [[SimpleTest]]: [MySQL] 17 pass(es).View details

#2

Posted by pcambra on September 29, 2011 at 9:28am

It should be done before the user check.

AttachmentSizeStatusTest resultOperations
1291908-keep_email_for_validate-2.patch756 bytesIdleFAILED: [[SimpleTest]]: [MySQL] Unable to apply patch 1291908-keep_email_for_validate-2.patch. Unable to apply patch. See the log in the details link for more information.View details

#3

Posted by andypost on November 9, 2011 at 10:21pm

Great but this should be configurable or not? this adds an option #583152-13: email confirmation option

#4

Posted by greggles on December 27, 2012 at 4:53pm
Title:Keep the email login entered by the user» Keep the email login entered by the user so it can be validated

Makes sense to me.

#5

Posted by System Message on December 27, 2012 at 6:47pm
Status:needs review» needs work

The last submitted patch, 1291908-keep_email_for_validate-2.patch, failed testing.

#6

Posted by greggles on December 27, 2012 at 7:30pm
Status:needs work» needs review

reroll.

AttachmentSizeStatusTest resultOperations
1291908-keep_email_for_validate-6.patch726 bytesIdlePASSED: [[SimpleTest]]: [MySQL] 17 pass(es).View details

#7

Posted by greggles on January 3, 2013 at 5:02pm
Version:7.x-1.x-dev» 6.x-1.x-dev
Status:needs review» patch (to be ported)

Now committed to 7.x - http://drupalcode.org/project/email_registration.git/commit/ceac58a

#8

Posted by greggles on January 3, 2013 at 5:47pm
Status:patch (to be ported)» fixed

Needed a slight re-roll but seems to work http://drupalcode.org/project/email_registration.git/commit/944b4c5

#9

Posted by System Message on January 17, 2013 at 5:50pm
Status:fixed» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

nobody click here