Validate the vimeo ID before adding to the library; improve regex.

I've been having issues with the regex as well.

Patch works for me, thanks

I guess my patch at #1497108: Support more Vimeo URL formats overlaps with this. I think having an idValid function makes sense but it should be static since it takes the id as a parameter and doesn't rely on the class's state.

Okay so #1497108: Support more Vimeo URL formats got committed. I think it might make sense to look at validating the ids too but this will need a re-roll.

Currently using the Simple API: http://vimeo.com/api/docs/simple-api
We could go for php or json instead of XML (so we don't have to use simplexml_load_file()). In any case here is the patch re-rolled currently using XML.

Format comparisons:
http://vimeo.com/api/v2/video/39078923.xml
http://vimeo.com/api/v2/video/39078923.php
http://vimeo.com/api/v2/video/39078923.json

Yeah I'd prefer JSON since we could avoid this issue #1180386: Use of copy() and simplexml_load_file() rather than drupal_http_request() causes Media:YouTube thumbnails to be empty but the is_valid function almost exactly mirrors MediaVimeoStreamWrapper::getVideoProperties() I think it might make sense to just use that for checking ids.

You mean this issue? #1504050: Use drupal_http_request() instead of of copy() and simplexml_load_file(), or else Media:Vimeo thumbnails may be empty

Yeah the point being use drupal_http_request() to fetch the URLs rather than loading them directly in simplexml_load_file()... but that's really academic since we should be using the existing function that does the request in that manner.

We decided on a solution for Media: YouTube, and can refactor that code to work here:

  /**
   * Check if a YouTube video id is valid.
   *
   * Check against the oembed stream instead of the gdata api site to
   * avoid "yt:quota too_many_recent_calls" errors.
   *
   * @return
   *   Boolean.
   */
  static public function validId($id) {
    $url = 'http://www.youtube.com/oembed?url=http%3A//youtube.com/watch%3Fv%3D'. $id;
    $response = drupal_http_request($url, array('method' => 'HEAD'));
    if ($response->code != 200) {
      throw new MediaInternetValidationException("The YouTube video ID is invalid or the video was deleted.");
    }
    return TRUE;
  }

  public function parse($embedCode) {
    $patterns = array(
      // Patterns.
    );
    foreach ($patterns as $pattern) {
      preg_match($pattern, $embedCode, $matches);
      // @TODO: Parse is called often. Refactor so that valid ID is checked
      // when a video is added, but not every time the embedCode is parsed.
      if (isset($matches[1]) && self::validId($matches[1])) {
        return file_stream_wrapper_uri_normalize('youtube://v/' . $matches[1]);
      }
    }
  }

Changed link into [#] d.o issue.

A patch to add a validId() method similar to the one used by Media: YouTube.

Tested #10 with a variety of deleted/invalid videos and verified that users were successfully warned.

Committed #10 to Media: Vimeo 7.x-2.x.