This module needed some lovin' and I thought I'd share what I've done so far. It's not a complete rewrite but should fix a few issues and add a few enhancements, including:

There's still a lot of work to do, including missing Fancybox options and Coder review, but I think it's a good start. Patch is against fancybox-7.x-1.x-dev-2011-02-25.

CommentFileSizeAuthor
#4 fancybox.zip14.28 KBgynekolog
#2 fancybox-directory-separator-oops.patch490 bytescaktux
fancybox-7.x-1.x-dev-2011-02-25.patch18.16 KBcaktux

Comments

matulis’s picture

matulis commented

Thanks for Your patch, fixed all bugs I had with Fancybox, very much appreciated!

caktux’s picture

caktux commented
StatusFileSize
new fancybox-directory-separator-oops.patch490 bytes

Glad it helped :) Here's another tiny patch fixing a bad use of directory_separator in case you run Drupal on Windows...

lvthunder’s picture

lvthunder commented

Can you post the whole module too? I don't want to mess with GIT to be able to apply the patch.

gynekolog’s picture

gynekolog commented
StatusFileSize
new fancybox.zip14.28 KB

caktux: thank you, works fine!

atachment:
version 7.x-1.x-dev-2011-02-25 fixed by caktux's patches (manually)

bas.hr’s picture

bas.hr commented
Status: Active » Fixed

Thank for summarizing everything in one big patch. I've applied patches to 7.x-1.x-dev branch.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.