For users who have only the administer og menus permission, adding and editing links in the menu works wonderfully. However, if a user has the administer menus permission, they will not see an existing menu link when editing items that are already in an OG menu.

Comments

rv0’s picture

Status: Active » Needs review
StatusFileSize
new17.66 KB

Hmm yes, I think I understand what's going on..
in D6 version, og_menu excludes users with administer menu permission.

I saw no real reason for this in D7 version, so I removed that.. But I forgot to update the code in node_prepare (which deals with existing nodes/menu links).

I have a patch here. Not committed yet. Keep in mind:
- I have a feeling some other things are still broken for users with administer menu permissions, e.g. it should also show the 'normal' menus, which is currently broken.
- This patch also fixes (unrelated) code indendation, thats why it's so big, the 'real' action is in og_menu_node_prepare

jastraat’s picture

Status: Needs review » Reviewed & tested by the community

I applied the patch, and now users with the administer menus privilege can see existing og menu links when editing. OG menu administration seems to still be working for users with only that privilege as well. So - at a casual glance, this looks like a good change.

Anonymous’s picture

Hey rv0,

Applied the patch: users with the administer menus privilege can see existing og menu links when editing a node, so means it's fixed for me!

Thanks for your effort on this great module!

rv0’s picture

Status: Reviewed & tested by the community » Needs work

I'll need to re-roll this patch

rv0’s picture

Status: Needs work » Fixed

Rerolled and committed.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.