Problem/Motivation

After adding an icon to a menu item, icon_css is regenerated, but the css cache isn't flushed

Proposed resolution

at the end of function menu_icons_form_submit add a call to drupal_clear_css_cache() after menu_icons_css_generate() has been called

CommentFileSizeAuthor
#5 menu_icons-flush_css_cache-1293244-5.patch374 bytesklaasvw
#4 menu_icons-flush_css_cache-1293244-4.patch478 bytesrooby
add_clear_css.patch131 bytesMaikelP
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

nicholas.alipaz’s picture

nicholas.alipaz CreditAttribution: nicholas.alipaz commented
Status: Active » Reviewed & tested by the community

+1 for this!

sjugge’s picture

sjugge CreditAttribution: sjugge commented

+1 for this patch.

fonant’s picture

fonant CreditAttribution: fonant commented

Patch does seem to help :)

rooby’s picture

rooby CreditAttribution: rooby commented
Title: CSS (cache) files not automatically rebuild. » CSS (cache) files not automatically rebuilt when the css file changes
Version: 6.x-2.4 » 7.x-3.x-dev
Status: Reviewed & tested by the community » Needs review
FileSize
menu_icons-flush_css_cache-1293244-4.patch478 bytes

That patch is not well rolled. Without reading the description that goes with it you have no idea where the line is being added.

Here is a reroll for drupal 7. It should be fixed there first anyways.
Functionality wise it is the same, just with an added comment.

It fixes the problem for me.

klaasvw’s picture

klaasvw CreditAttribution: klaasvw commented
Issue summary: View changes
FileSize
menu_icons-flush_css_cache-1293244-5.patch374 bytes

What about clearing the CSS cache any time the menu icons CSS is rebuilt? The solution from #4 won't work with menu icons added through the node form.

dscl’s picture

dscl CreditAttribution: dscl commented
Status: Needs review » Reviewed & tested by the community

#5 Works like a charm. :)
Thanks a lot!