content_view() not recursive safe

I'll put in a recursion check tonight that prevents token from looping that way -- it's a danger if enough things use tokens that the module itself should take care of it. Thanks!

Mark, I've committed a simple fix to the dev branch of Token. It allows tokens to go two layers deep, but no deeper. Do you think this is sufficient?

--Jeff

http://cvs.drupal.org/viewcvs/drupal/contributions/modules/token/token.i...

I ran into this same problem while implementing token support into link module. The current recursion check doesn't prove to be effective in preventing the problem, as the actual depth is never actually checked before the module_invoke_all('token_values', $type, $object).

I added the check in such as this:

  elseif ($depth < 3) {
    $tmp_tokens = module_invoke_all('token_values', $type, $object);
    $tokens[$type][$id] = $tmp_tokens;
  }

It prevents the loop but the tokens were never replaced at all.

I think the real problem here is the call to content_view() in token_cck.inc. Perhaps we should remove it entirely and live with the 'view' version of each cck field unpopulated?

We can't really do that -- Although I can't believe I left the depth check out. Heh.

The problem is that the 'cleaned' versions of each field, the ones that are display-safe, are often built by the formatters. And the formatters don't do anything until the view call is made. I'll check that recursion check again. Heh. Thanks :)

@mfrederickson - Which version of token.inc are you testing against? Neither the latest build nor the 1.7 release work for me with the latest DRUPAL-5 version of viewfield.module. I'm getting an infinite loop in the token_get_values() function. As near as I can tell it's from this:

  elseif ($depth = 1) {
    $depth++;
  }
  ...
  $depth--;

Which never gets to the else block. I changed that to == and it seems to be working fine. Patch attached.

And to follow up on this, this will not work if there are multiple things calling token on the same page - for example a teaser list wherein each teaser has a viewfield exposed.

I suppose depth could be a keyed array off of $type and $object but I don't think that could reliably handle this case, either.

Attached is a patch that keys depth off of the $id also used for the token cache in the function (I moved the declaration up). This will allow multiple CCK items in the same request to use tokens as long as they are unique.

The patch in #10 didn't key by both $type and $id, this one does.

Another day, another patch. This one is simpler, and allows for multiple modules (custom_pagers, pathauto, etc) to use token in the same request without content_view using up the depth counter. It just sets a boolean flag when it starts generating for one call, and clears it out again when done. I did a test of nested viewfields, and they seemed to work correctly. Still not positive this is the best approach, but ti satisfies my current use cases.

Sorry for all the rapid posting here, but this is a feature very much needed for my sanity.

This same bug was messing up pathauto in certain circumstances.

The patch in #12 solves it for me.

@Eaton - I'm planning to commit this tomorrow unless you object. I won't make a new branch so at least it will be easy to roll back.

i marked http://drupal.org/node/160671 as a duplicate of this.

This is now fixed for DRUPAL-5 - needs to be ported

Fixed the problem for me with link.module too FYI, nice catch!

Ported in eaton's work this past weekend.

Does anyone know if this patch has been incorporated into later upgrades of this module?

@alimc29 - yes, it should be in all current versions of token now (i.e. 5.x-1.10, 6.x-*). If you are getting similar behavior to this, please post a new (and detailed) bug report.

Thanks.