Having ns_poll an independent content provider would make it easier to extend the functionality.

CommentFileSizeAuthor
#6 poll-content-1293496-5.patch13.11 KBjohanh
#4 poll-content-1293496-3.patch16.9 KBjohanh
#1 poll-content-1293496-0.patch6.15 KBjohanh

Comments

johanh’s picture

johanh commented
StatusFileSize
new poll-content-1293496-0.patch6.15 KB

A patch, the first try.

Removed all dependencies of article content type and field group.

fabsor’s picture

fabsor commented
Status: Active » Needs review

This needs review

fabsor’s picture

fabsor commented
Status: Needs review » Needs work

This breaks the current functionality, since you can't refer to polls in articles anymore. We need to provide another feature that adds a field on the article so that you can refer to polls.

johanh’s picture

johanh commented
Status: Needs work » Needs review
StatusFileSize
new poll-content-1293496-3.patch16.9 KB

This patch divides the old ns_poll into two features: ns_poll and ns_article_poll. Ns_poll now only includes user permissions for polls. Ns_article_poll have the field for ns_article and field group.

I'm not sure we should include user permissions in ns_poll. The roles and permissions for polls could differ between projects based on NodeStream. But we have to have something in the feature otherwise it is not created. (I have tried.) Maybe only have user permissions for administrator or some other role which should exist in most sites?

fabsor’s picture

fabsor commented
Status: Needs review » Needs work

The Create, Edit and Delete permissions should be part of the ns_poll feature. They can be exported through features as usual, and then adopted to use the default config module. Information about how this can be done can be found on the Project page

You can also have a look at the ns_article feature, for instance.

johanh’s picture

johanh commented
Status: Needs work » Needs review
StatusFileSize
new poll-content-1293496-5.patch13.11 KB

Ok, new try.

This time default configuration of permissions is added to ns_poll.
Also added drupal variable "language_content_type_poll" to ns_poll.

fabsor’s picture

fabsor commented
Status: Needs review » Needs work

We are still missing the permissions from this feature, we need that as well before we can get this in. Sorry to be problematic =)

fabsor’s picture

fabsor commented
Status: Needs work » Fixed

This should be fixed now.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.