Remove the custom library code and completely replace it with the view. We have basic views support (see #1224766: Remove default media browser and replace with a default view), and once the Views Library is a bit more stable we want to remove the custom library code. Lowering priority until some other tasks are completed.
| Comment | File | Size | Author |
|---|---|---|---|
| #9 | remove-old-media-browser-1293660-9.patch | 10.88 KB | devin carlson |
| #1 | admin_content_media_view_1.txt | 54.31 KB | askibinski |
| #1 | views_media_library_thumbnails.png | 432.31 KB | askibinski |
| #1 | views_media_library_list.png | 94.87 KB | askibinski |
Comments
Comment #1
askibinski commentedI attached a view that mimics the module's media library page at admin/content/file.
See the screenshots for examples.
It requires:
Points of attention:
Also, the edit and delete links are now custom fields, it would be cleaner if file_entity would provide these view fields.
Comment #2
dave reid@askibinski: This is a separate issue than intended. This is to remove the old Media browser library plugin, and you have posted code to replace admin/content/file/media with a View, which need to be a different issue.
Comment #3
dave reidMarking #1293908: Respect file type restrictions in media browser library view as a blocker to this issue.
Comment #4
jenlamptonWhat tasks are the blockers for removing the custom Library tab?
Comment #5
dave reidI...just linked to it.
Comment #6
jenlamptonHello cache. Thx :)
Comment #7
askibinski commentedJust FYI:
Personally, I dropped the whole views approach and found that
http://drupal.org/project/media_browser_plus
has got a far better solution. Even with drag-n-drop to different libraries, which I don't see happen in Views in the near future.
Comment #8
dave reidMoving this as a major task for next week's DrupalCon sprint. It would be really good to get rid of this code.
Comment #9
devin carlson commentedThe attached patch removes the old library code.
Comment #10
johnpitcairn commentedDoes this still depend on #1293908: Respect file type restrictions in media browser library view ? I wouldn't want to see the library go away before file type restrictions are good for fields. Hopefully for wysiwyg too.
Comment #11
dave reidThis has been committed and fixed along with #1293908: Respect file type restrictions in media browser library view with http://drupalcode.org/project/media.git/commit/9bce5cc. Thank you everyone for your work on this issue! We finally got rid of a bunch of old code!