Problem entering default expire time

Good bug report. I've confirmed this behavior. Rats!

What's interesting is that roles that had default expirations before the update continue to have expirations now. But once I edit them, the default expiration goes away.

I've found the problem. There was some code that I didn't update correctly from 6.x to 7.x when I built the new release. The attached patch should fix that problem (as well as the Views integration problem noted at #1291466: Views integration not working).

Now when you go through the steps Scipr outlined above, the default duration does get set.

Scipr, do you know how to apply patches? If you apply, test and confirm this patch, I'll update the module.

Again, thanks for the excellent bug report, Scipr. Made it easy to isolate and test.

Testing is great!!

Did you remember to run update.php before you began this test sequence? The database schema does change between beta1 and beta2.

Thanks

No. Can't duplicate the problem. Can you get to the database? Are you using mysql or something else? For my installation (mysql) the role_expire_length table looks like this:

CREATE TABLE `role_expire_length` (
  `rid` int(10) unsigned NOT NULL COMMENT 'The role_id.',
  `duration` tinytext COMMENT 'A strtotime-compatible duration string',
  PRIMARY KEY (`rid`)
) ENGINE=InnoDB DEFAULT CHARSET=utf8 COMMENT='Length in days to assign each role by default.';

Is this what yours is?

(To create this CREATE TABLE command, I used phpmyadmin and did an 'export' of the role_expire_length table, Structure-only.)

Yep. You've hit the nail on the head. I completely forgot about that use case(!) A revised patch is on its way.

BTW, testing for this uncovered another bug. If you edit a role a second time and don't change the non-empty default duration, you'll get a PDO error.
The bug:
1. Go to admin/people/permissions/roles and click "Edit role" for role A.
2. Add a duration to role A and click "Save role".
3. Still on admin/people/permissions/roles, click "Edit role" for role A (again).
4. Don't change anything and click "Save role".
5. Observe the error message.

The patch'll fix this second error too. Problem is, I'm tied up until at least Sunday.

Scipr, glad you're now part of the Drupal community. Your testing and reporting are invaluable.

The following patch addresses the problem Scipr in #3ff, and the one I found in #8.

To test #3:

1. If role_expire is installed, completely uninstall role_expire:
   1. Go to admin/modules and uncheck role_expire and click "Save configuration"
   2. Go to admin/modules/uninstall and click the 'Uninstall' checkbox for role_expire and click "Uninstall" button.
2. Apply role_expire-1293846-10.patch.
3. Install role_expire -- go to admin/modules and check 'role_expire' and click "Save configuration"
4. Set a default duration on the admin/people/permissions/roles/edit role page.
5. Click 'edit role' again and verify that the default expiration you set in the previous step appears in the field.

To test #8:
(This was a total rewrite of role_expire_set_default_duration.)

1. After testing #3, simply click "Save Role" without making any changes.
2. Verify that you don't get an error message and that the value that was in the role's 'Default duration' field is unchanged.
3. Regression test! Verify continued correct behavior of the module.

Additional changes:

1. Added a check that the duration field is actually a string and not an int. If the duration field is an int, you'll see an error message that tells you to run update.php. (This was a total rewrite of role_expire_get_default_duration.)
2. The views api was relaxed to accept any form of 3.x as a valid views version. (See #1291466: Views integration not working)

I tested the patch and it now saves the default duration. :)

My question is if I give the role to a user and the field to enter the default duration pops up, should the default duration show up?

Patch #10 work for me !

As it currently stands, if you use the default, you only see the default duration after the user has been saved. There's a 6.x patch that prefills the expiry field with the default duration on load. Once that patch is accepted, I plan to create a patch for the 7.x version that does the same thing.

i'm attaching the patched module with #10 thank you sharplesa!

and also patch from

"add expire time to role" in Rules adds from current day, but not the user's role expiration day at http://drupal.org/node/1370262, thank you davidwatson!

all working good :)

I love you Liliplanet! I have a client using GoDaddy without SSH and I didn't feel like doing anything with their stupid FTP panel. This patched version fixed the issue for me.

RE #14 Liliplanet: If you have fixed this could you attach a patch to this issue.

See here for instructions if you need them. http://drupal.org/node/707484

That would be great and I could review and possibly commit that to the main module. If you can't do that let me know and perhaps we can see what changes you made to support this. I suspect you edited the beta rather than the dev version. Is that right?

Hi stewsnooze, thank you! yes the patches were done to the 7.x-1.x-dev version.

The patches include are:

http://drupal.org/files/role_expire-1293846-10.patch
http://drupal.org/files/1370262--role-expire-rules-2--7.patch

Here is also a block for users to view their expiry date. I did this because the date did not show up on the profile. The role in this instance is called 'Contributor'.

Thanks to everyone for patching the module and getting it fixed. The latest dev release (7.x-1.0-beta1+6-dev from 2012-Sep-24) works just fine, and the user's expiry date is also shown on their account page.

A tip to others and a reminder to myself: If you add the role to a user with Rules during checkout with Commerce for example, remember to set the expiration time for the user's role, otherwise the role expiration time will be empty.

The two rules to add

• Add user role
• Set expire time for role

Really, would we be able to solve the issues Commerce roles expiry as commerce_sp seems to be abandoned as that would be absolutely amazing.

Perhaps we could have a rule that sends an expiration (ie 3 days before) warning for the user?

Looking most forward to your development, thank you!

I think it can be done with Rules Scheduler, see this post by trevorkjorlien: http://drupal.org/node/827594#comment-5254316

It seems like a lot of work, perhaps there is a simpler method? :-)

I was having this problem so I updated to the .dev version, after setting the default expire time on the role - I went back in to change the default expire time and I get this message:

PDOException: SQLSTATE[23000]: Integrity constraint violation: 1062 Duplicate entry '5' for key 'PRIMARY': INSERT INTO {role_expire_length} (rid, duration) VALUES (:db_insert_placeholder_0, :db_insert_placeholder_1); Array ( [:db_insert_placeholder_0] => 5 [:db_insert_placeholder_1] => 183 ) in role_expire_set_default_duration() (line 144 of /sites/all/modules/role_expire/role_expire.module).

Which patch is actual for 7.x-1.x-dev version? #10 ?

#10 doesn't apply. Re-rolled on top of latest dev. Also added hook_update_N() to address column type change.

I tested the patch in #24; I was getting an error before when re-saving a role with an expiration, but that no longer occurs and it saves properly. Good work!

The patch works great but I think it is really important to have a new beta release because the current beta release is just broken, so things can not get worse... :(

I have tried to reproduce the problem using latest dev with no success. Could you check it out again? Anyway, the patch does not cleanly apply. I think the module works fine now. If you still find the same problem, please reopen and reroll patch.

Looking at patch #24, isn't this directly connected to the missing default durations functionality?

https://www.drupal.org/project/role_expire/issues/2891810#comment-12661524

So I've reviewed this in further detail, and compared to the original patch from #1280450.

I think there is value in what patch #24 has, and should be combined with what previously existed in from #1280450. I have created a single patch that brings the two together against the 7.x-1.x branch.

It can be found here: https://www.drupal.org/project/role_expire/issues/2891810#comment-12661918

Please review and provide your feedback, thanks.

Now #2891810: 7.x-1.0-rc1 rolls back some features from 7.x-1.0-beta2 (Default durations functionality) is fixed. So I close this issue. Thanks to everyone and specially to ron_s!