one-time batch import fails due to separation of sf_import into multiple files

You would want this line module_load_include('inc', 'sf_import', 'sf_import.batch'); at the beginning of function sf_import_create_submit (line 250).

I'll try to do some work on this tomorrow.

You probably need to add $batch['file'] and specify the full path to sf_import.batch.inc before calling batch_set.

Oh, I see, you're creating the batch in sf_import.batch.inc itself...

In 7.x, the full function is like this:

/**
 * Submit callback for sf_import_create form.
 *
 * @param array $form
 * @param array $form_state
 * @param int $ongoing
 */
function sf_import_create_submit($form, &$form_state, $ongoing = 0) {
  // Create a new batch job to do the import.
  module_load_include('inc', 'sf_import', 'sf_import.batch');

  $extra_options = array();
  $extra_options['extra-linked'] = $form_state['values']['extra-linked'];
  $extra_options['extra-where'] = $form_state['values']['extra-where'];

  $batch = sf_import_create_batchjob($form_state['values']['fieldmap'], $extra_options);
  batch_set($batch);
}

Could you try changing the function in your 6.x to be something like that?

If this works, I'll make the change in 6.x. (I usually only commit to 7.x.)

I have this same error.

I included the batch file in create submit and, while it fixed the php error, I still can't do batch imports. I have made some progress though. I can use the drush import, but only for salesforce user to drupal user. I may have found a bug for importing nodes. When I tried import nodes via drush I would get the error "Could not find import function for type node_". Looking through the code I found in sf_import.drush.inc starting on line 249 the following code.

// Prepare for import
$type = $map->drupal;
if (strpos($type, 'node_') === 1) {
$type = 'node';
}
$function = 'sf_' . $type . '_import';
if (!function_exists($function)) {
drush_die("Could not find import function for type " . $type);
}

This code is supposed to change the drupal type from a specific "node_" to just "node", but it wasn't since my error message was saying "node_". The problem is that strpos is returning 0, which means that "node_" was matched starting at index 0, not 1. Changing the conditional to match "node_" at index zero allows me to import nodes via drush. The fixed code looks like this:

// Prepare for import
$type = $map->drupal;
if (strpos($type, 'node_') === 0) {
$type = 'node';
}
$function = 'sf_' . $type . '_import';
if (!function_exists($function)) {
drush_die("Could not find import function for type " . $type);
}

However, the batch operation in the admin still fails. I set up a bunch of dd's in the salesforce code to investigate and the operation function which is specified for the batch is never called.

I hope this helps move toward a solution for the batch import problem in drupal 6.

The reason that the function specified for the batch is never called is because the batch also needs to know where to find the function definition; when the batch is defined (in sf_import_create_batchjob), it should be given a file argument:

  return array(
    'title' => t('Importing'),
    'operations' => array(
      array('sf_import_batchjob', $params)),
    'finished' => 'sf_import_batchjob_finalize',
    'file' => drupal_get_path('module', 'sf_import') . '/sf_import.batch.inc',
  );

Attached is a patch that addresses both include issues; apply it to the dev branch of the code and batch importing should work (it works for me now).

Committed, thank you @klflote! http://drupalcode.org/project/salesforce.git/commit/7905bab

Thanks, this should fix in 7.x as well. I'll try to commit soon.

Committed patch from #7 to 7.x-2.x-dev http://drupalcode.org/project/salesforce.git/commit/04fc211

Thanks for the update.

I upgraded to the latest Dev 7.x-2.x, but got this error on batch import. Any idea what's happening?

Message:

•  Primary field [field_sfuid:value] specified in map prematch not defined.
•  Import failed.

Error on prior import progress bar page:

An AJAX HTTP error occurred. HTTP Result Code: 500 Debugging information follows. Path: /batch?id=402&op=do StatusText: Service unavailable (with message) ResponseText: PDOException: SQLSTATE[23000]: Integrity constraint violation: 1062 Duplicate entry '' for key 'name': INSERT INTO {users} (uid, name, pass, mail, theme, signature, signature_format, created, access, login, status, timezone, language, picture, init, data) VALUES (:db_insert_placeholder_0, :db_insert_placeholder_1, :db_insert_placeholder_2, :db_insert_placeholder_3, :db_insert_placeholder_4, :db_insert_placeholder_5, :db_insert_placeholder_6, :db_insert_placeholder_7, :db_insert_placeholder_8, :db_insert_placeholder_9, :db_insert_placeholder_10, :db_insert_placeholder_11, :db_insert_placeholder_12, :db_insert_placeholder_13, :db_insert_placeholder_14, :db_insert_placeholder_15); Array ( [:db_insert_placeholder_0] => 403 [:db_insert_placeholder_1] => [:db_insert_placeholder_2] => pbNxnqRyJnqQ7OHt0H742u2W4HuBwvppJbZPL5K-ODU [:db_insert_placeholder_3] => [:db_insert_placeholder_4] => [:db_insert_placeholder_5] => [:db_insert_placeholder_6] => [:db_insert_placeholder_7] => 1333036128 [:db_insert_placeholder_8] => 0 [:db_insert_placeholder_9] => 0 [:db_insert_placeholder_10] => 1 [:db_insert_placeholder_11] => [:db_insert_placeholder_12] => [:db_insert_placeholder_13] => 0 [:db_insert_placeholder_14] => [:db_insert_placeholder_15] => a:8:{s:16:"ckeditor_default";s:1:"t";s:20:"ckeditor_show_toggle";s:1:"t";s:14:"ckeditor_popup";s:1:"f";s:13:"ckeditor_skin";
s:4:"kama";s:15:"ckeditor_expand";s:1:"t";s:14:"ckeditor_width";
s:4:"100%";s:13:"ckeditor_lang";s:2:"en";s:18:"ckeditor_auto_lang";s:1:"t";} ) in drupal_write_record() (line 6975 of /var/docroot/includes/common.inc).

I need to be able to import a user base from Salesforce -> Drupal via this method. Is that what it's designed for?

Many thanks in advance,

The import/export functionality does not work well out of the box for user accounts. You'll need to implement `hook_salesforce_api_pre_import()`, look at the data you are getting from Salesforce, and halt processing on records where, for example, the field you've mapped to a username is '', which is what I think is happening in your error message above.

Hi Kostajh, I also get something similar (An AJAX HTTP error occurred. HTTP Result Code: 500 Debugging information follows. Path: /batch?id=266&op=do StatusText: Service unavailable (with message) ResponseText: PDOException: SQLSTATE[23000]: Integrity constraint violation: 1062 Duplicate entry '267-6' for key 1: INSERT INTO {users_roles} (uid, rid) VALUES (:db_insert_placeholder_0, :db_insert_placeholder_1); Array ( [:db_insert_placeholder_0] => 267 [:db_insert_placeholder_1] => 6 ) in user_save() (line 599 of /home/theveryl/public_html/kings/modules/user/user.module). )
...but i don't know how to fix it with the hint you explained (i'm not a coder) : "...You'll need to implement `hook_salesforce_api_pre_import()..."

How and where should I implement this hook? (in case it is the fix form me too)

Thanks a lot in advance

nico

@Fixdit. I'm having a very similar trouble with salesforce, but I'm no expert coder and I really don't know where to apply the hook recommended by kostajh. Could you give some hint on this in case it worked for you? I have to import a batch of users and I think my problem is having the username mapped, but I don't want to map it to a sustitutive field.

Well, if you have some time for this I would really appreciate it.

Thanks in advance

nico