Download & Extend
Issues

Code style fix for field_ui.test

Posted by Chi on September 29, 2011 at 2:58am
Project:Drupal core
Version:7.x-dev
Component:other
Category:task
Priority:minor
Assigned:Unassigned
Status:closed (fixed)
Issue tags:needs backport to D7

Issue Summary

Attached

Login or register to post comments

Comments

#1

Posted by Chi on September 29, 2011 at 2:59am
Status:active» needs review
AttachmentSizeStatusTest resultOperations
code_style_field_ui.test-0.patch1.13 KBIdlePASSED: [[SimpleTest]]: [MySQL] 33,149 pass(es).View details

#2

Posted by larowlan on September 29, 2011 at 1:03pm
Status:needs review» reviewed & tested by the community

Straight forward

#3

Posted by catch on September 29, 2011 at 1:47pm
Status:reviewed & tested by the community» needs work

While we're there could we remove this double space before the strtolower? Same thing appears each time.

+    $type_name =  strtolower($this->randomName(8)) . '_test';

#4

Posted by Chi on September 29, 2011 at 2:03pm
Status:needs work» needs review
AttachmentSizeStatusTest resultOperations
code_style_field_ui.test-1.patch1.13 KBIdlePASSED: [[SimpleTest]]: [MySQL] 33,133 pass(es).View details

#5

Posted by TR on September 30, 2011 at 4:54am
Status:needs review» reviewed & tested by the community

Looks good to me for both D8 and D7.

#6

Posted by catch on September 30, 2011 at 4:59am
Version:8.x-dev» 7.x-dev

Thanks! Committed and pushed. Moving to 7.x for webchick.

#7

Posted by webchick on September 30, 2011 at 7:52pm
Status:reviewed & tested by the community» fixed

Committed and pushed to 7.x. Thanks!

#8

Posted by System Message on October 14, 2011 at 8:01pm
Status:fixed» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

nobody click here