We have very crappy auto generated names for our page manager handlers in several places. Lets fix this.

CommentFileSizeAuthor
#1 handlernames_1294644_1.patch1.51 KBpontus_nilsson

Comments

pontus_nilsson’s picture

Status: Active » Needs review
StatusFileSize
new1.51 KB

Had a look at this. There was one handler in ns_search that had the default handler name, patch fixes that. Other than that I think they look ok. See grep below for state after patch applied to ns_core.

grep -R '$handler->name =' .
./features/ns_ch_blog/ns_ch_blog.pages_default.inc:  $handler->name = 'ns_ch_blog_blog';
./features/ns_ch_blog/ns_ch_blog.pages_default.inc:  $handler->name = 'ns_ch_blog_blog_post';
./features/ns_ch_blog/ns_ch_blog.pages_default.inc:  $handler->name = 'ns_ch_blog_site_template';
./features/ns_ch_blog/ns_ch_blog.pages_default.inc:  $handler->name = 'page_ns_ch_blog_blog_panel_context';
./features/ns_ch_web/ns_ch_web.pages_default.inc:  $handler->name = 'ns_ch_web_article';
./features/ns_ch_web/ns_ch_web.pages_default.inc:  $handler->name = 'ns_ch_web_article_draft';
./features/ns_ch_web/ns_ch_web.pages_default.inc:  $handler->name = 'ns_ch_web_article_revision';
./features/ns_ch_web/ns_ch_web.pages_default.inc:  $handler->name = 'ns_ch_web_default';
./features/ns_ch_web/ns_ch_web.pages_default.inc:  $handler->name = 'ns_ch_web_site_template';
./features/ns_ch_web/ns_ch_web.pages_default.inc:  $handler->name = 'ns_ch_web_topic';
./features/ns_ch_web/ns_ch_web.pages_default.inc:  $handler->name = 'page_ns_ch_web_promos_panel_context';
./features/ns_ch_web/ns_ch_web.pages_default.inc:  $handler->name = 'page_ns_ch_web_topic_editor_panel_context';
./features/ns_search/ns_search.pages_default.inc:  $handler->name = 'ns_search_node';
./features/ns_ch_rss/ns_ch_rss.pages_default.inc:  $handler->name = 'page_ns_ch_rss_topic_editor_panel_context';
./features/ns_ch_rss/ns_ch_rss.pages_default.inc:  $handler->name = 'page_ns_ch_rss_topic_list_panel_context';
pontus_nilsson’s picture

Oh maybe these are also lame names?

page_ns_ch_blog_blog_panel_context
page_ns_ch_web_promos_panel_context
page_ns_ch_web_topic_editor_panel_context
page_ns_ch_rss_topic_editor_panel_context
page_ns_ch_rss_topic_list_panel_context
fabsor’s picture

Status: Needs review » Fixed

I think all of this is already commited as far as I can see.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.