While this is no big deal, it is a coding error. If I have no messages yet click the submit button, I get the error shown in the attached image.

CommentFileSizeAuthor
#6 feedback.admin-empty.6.patch516 bytessun
#5 feedback.admin_.xibun1_.patch761 bytesxibun
#1 feedback-1294764.patch664 bytesAnonymous (not verified)
feedback_error.png36.96 KBbike2live

Comments

Anonymous’s picture

Anonymous (not verified) commented
StatusFileSize
new feedback-1294764.patch664 bytes

Fix attached. Best regards!

Anonymous’s picture

Anonymous (not verified) commented
Status: Active » Needs review
xibun’s picture

xibun commented
Status: Needs review » Reviewed & tested by the community

patch works! thanks. (note: it also removes the unused variable $update)

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Reviewed & tested by the community » Needs work

If there are no messages, then we need to hide (not output; i.e., #access => FALSE) the submit button in the form instead.

xibun’s picture

xibun commented
Status: Needs work » Needs review
StatusFileSize
new feedback.admin_.xibun1_.patch761 bytes

good point: better UI. here is the updated patch.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Needs review » Fixed
StatusFileSize
new feedback.admin-empty.6.patch516 bytes

Thanks for reporting, reviewing, and testing! Committed attached patch to 7.x-2.x.

A new development snapshot will be available within the next 12 hours. This improvement will be available in the next official release.

xibun’s picture

xibun commented

nice idea to look for $entries - didn't see that one!

question: javier.alejandr... had spotted an unused variable $update (currently on line 122) - I know it's unrelated.. but why not remove it?

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.