To allow more flexible search pages a placeholder could be a good option to enable this.
It would be something that allows a limited set of placeholders + 1 dynamic one eg. a list of tokens they can use with a developer hook that adds more tokens.
%nid, %tid, $vid, %uid

This allows us to remove the apachesolr_taxonomy module but good documentation should be added to prevent that people suddenly loose this option. Maybe example pages should be added but deactivated?

Dynamically this thread emerged into a issue so that even core search page (the replacement of it) is also implemented by search pages. This generates a better consistency in the UI and introduces less code, more flexibility

Comments

pwolanin’s picture

I'm a little leery of making this too complex - especially if we expect apachesolr_views to be usable again.

Let's focus for now on getting the simplest possible implementation that would let us remove the taxonomy sub-module.

nick_vh’s picture

StatusFileSize
new20.26 KB

Including is a patch that allows for placeholders in the search path.
Currently it does not allow custom indexes to be called yet but that is easily possible by using a hook

hook_apachesolr_search_types($search_types)

An array of such a search_type exists out 3 properties + their ID

'ss_language' => array(
'name' => apachesolr_field_name_map('ss_language'),
'default menu' => 'search/language/%',
'title callback' => 'apachesolr_get_language_title',
),

I'd suggest for people to play a bit with it. It comes with some sensible default selectors in the admin page.

nick_vh’s picture

StatusFileSize
new20.29 KB

Little update with some tiny typo + a title bug

So far I am not able to override the taxonomy pages (taxonomy/term/%) because I think I need a menu alter to manually switch off some of the alterations. I guess we should figure out how other modules override them without using hook_menu_alter

nick_vh’s picture

StatusFileSize
new81.08 KB

Just for people that are concerned about UI. This interface changes the default values whenever a certain type is selected. As discussed before it is important to keep this as simple as possible because it is not the intended purpose to replace views

pwolanin’s picture

Status: Active » Needs work

The description text under Path is still referring to tokens.

nick_vh’s picture

Status: Needs work » Needs review
StatusFileSize
new27.15 KB

A new patch means new stuff!

  • Custom value type added, this means you can dynamically build an url while still having control over which facet you want to sort on. Simply select Custom search type and use something like tid:% to have the page working dynamically
  • Facet links were broken and are fixed in this version of search pages
  • Taxonomy can be easily overridden by selecting the taxonomy type in the selector list
  • Description text improved

TODO :
I can't seem to figure out why Drupal doesn't let me change the taxonomy title when the path is exactly the same. I guess if there is no solution for this we can still consider using drupal_set_title() for having custom titles. Maybe if someone can test if this only happens for me or for everyone

nick_vh’s picture

StatusFileSize
new32.4 KB

Last update of the day

As usual a little list again

  • It is now possible to set the amount of search results per custom search page
  • It is also possible to enable or disable the spellcheck per custom search page
  • apachesolr_taxonomy module removed from the module

This patch does have some more work to be done. A user should be able to select how the output could be themed, so taxonomy term results show up as they would would/could do in core drupal

nick_vh’s picture

StatusFileSize
new2.51 MB
new2.51 MB
new85.74 KB
new201.27 KB
new40.6 KB
new41 KB

New day, new improvements on the UI side. There has been some changes in the way that solr creates an initial search page. The core search page is now embedded in the search pages page so it allows (I think) a better way of controlling the different search pages, wether it is the core search page that we override or any other one.

Included are some snapshots Before and After. Could someone please take a look at the screenshots and verify and comment on the clarity of the help text?

The taxonomy title I was talking about earlier has also been solved. It was a matter of menu_local_task menu_default_local_task being without a parent and when a task is a single page and does not have a parent it shows the page title of the only parent it can find : the frontpage

Todo : Remove clutter that was used to generate the core search page from the module

nick_vh’s picture

Title: Placeholder in search pages » Refactoring of the search pages
StatusFileSize
new17.09 KB
new46.05 KB

This is becoming more like a generic issue for search pages and refactoring some of apache solrs functionality regarding search pages so I changed the title
This is a solution for issue #1246422: No retain current filters checkbox in custom search page (neither for autocomplete) (or at least a part of it)

nick_vh’s picture

keep-filters.jpg

nick_vh’s picture

Issue summary: View changes

Updated issue summary.

nick_vh’s picture

New patch that reworks a little of the UI of the custom search pages to look more similar and coherent (took example from the new views UI)

nick_vh’s picture

StatusFileSize
new46.31 KB

Done a small code review with coder. No functionality changes in this patch

nick_vh’s picture

StatusFileSize
new49.46 KB

Some documentation issues and spacing + a newline issue. Patch should apply cleanly to latest dev branch

nick_vh’s picture

Status: Needs review » Closed (fixed)

Commited

nick_vh’s picture

Status: Closed (fixed) » Fixed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Anonymous’s picture

Issue summary: View changes

Updated issue summary.