OGM Creates posts in a group with Public visibility

Hey dmgenesys,

I discovered this on my site as well. The test ogm does to determine whether a group is public or private (and therefore whether the post should be public or private) is not working on my site. I did a search and found that changing line 360 in og_mailinglist_transport.inc fixed this problem for me:

// $node->og_public = $is_public;
$node->og_public = FALSE;

Cheers,

Tobias

Could either of you check what the og_private value is for groups where posts are should be created as private but instead are created as public? I don't see anything obviously wrong with my code.

I just ran into this issue again after upgrading to your latest code in early august, and had to spend 30 minutes changing privacy settings on dozens of posts. not good.

Basically what is happening here is that there are two places on my site where og privacy is determined - one is in og (for overall visibility of groups on the site) and one is in og_access settings (for og content visibility within groups). og_mailinglist is looking for the "privacy" setting for the group.

on my site, groups are visible in the directory but posts to groups are private. in this configuration, og_mailinglist was causing unexpected behavior by making posts public while posts directly to the site remain private.

to avoid this in the future when you upgrade og_mailinglist code, i have now set it up so that all groups are marked as private og_private=1), which works for the time being because it doesn't matter that groups don't appear in the groups directory or signup forms etc because we don't use that functionality at the moment. in the future this will change when we get groups working properly and we want to encourage users to find and sign up to groups.

A more permanent solution to support my use case and others would be to have an option in og_mailinglist settings for privacy of posts - e.g. always public, always private, follow og_private

Cheers,

Tobias

I can't agree with tobias' suggestion that there be a separate preference in og_mailinglist that would affect privacy of posts. og_mailinglist should handle as little as possible, and just be a conduit for og content to be sent and received by email. The privacy should solely be based on the privacy options set for a group itself. If there is a bug in the implementation, then this should be fixed of course... but surely this is the wrong module to contain another layer of privacy options?

In 7.x I removed that part completely so og_access field is not set at all. In that case og_access decides publicity by checking all parent groups. If any of these groups is private, the post is private as well.

It should work just fine for 7.x, won't fix for 6.x.