Attached is patch that gets this working with entityreference module.

CommentFileSizeAuthor
#12 1295276.patch2.88 KBjohn morahan
#10 entityreferences_views_1295276_10.patch.txt1.58 KBperarnet
#9 entityreferences_views_1295276_9.patch3.52 KBperarnet
#8 1295276.patch690 bytesjohn morahan
#4 entity-reference-compatibility-1295276-4.patch7.08 KBjohanh
#3 entity-reference-compatibility-1295276-3.patch7.08 KBfabsor
0001-added-entityreference-compatibility.patch2.62 KBthat0n3guy

Comments

fabsor’s picture

fabsor commented
Status: Patch (to be ported) » Needs review

Awesome, I will have a look at this very soon. Just setting the proper status for now.

that0n3guy’s picture

that0n3guy commented

I should note that I didn't include any of the "search" functionality for it as I don't know what I'm doing w/ most of the views stuff :).

Also, now that I think about it... I didn't really test the edit functionality, but create works great.

fabsor’s picture

fabsor commented
StatusFileSize
new entity-reference-compatibility-1295276-3.patch7.08 KB

Great initial work on the patch! I have been thinking about adding support for this for a while, so it's great that the work finally got kicked off.

I had a look at your work, and it is a great start. However, since the entity reference module essentially supports all entities, and that is it's purpose, I think our integration with it needs a little more support than just nodes, and also an easy way of providing support for more entities defined in contrib.

The attached patch adds a new hook to references dialog, hook_references_dialog_admin_paths(). This hook let's you define where the add and edit page callback is located for different entities. The module itself then provides an implementation of this hook that gives us the ability to use the references dialog module on all core entities (users, taxonomy terms, taxonomy vocabularies, nodes).

I also added support for views.

Please review and test it out!

johanh’s picture

johanh commented
StatusFileSize
new entity-reference-compatibility-1295276-4.patch7.08 KB

Tested patch by fabsor. Not a thorough testing by everything seems fine except a minor bug with edit of nodes, which I have fixed in this patch.

fabsor’s picture

fabsor commented
Status: Needs review » Fixed

I pushed this in. The patch does not disturb any existing functionality, so I think it's better to get it in and then get bug reports.

pontus_nilsson’s picture

pontus_nilsson
Location Stockholm
commented

I tried upgrading to latest dev and changing the widget to use add, edit search dialogue and got the error below.

Maybe this is because the dev version wasn't installed first (alpha then upgraded)?

    Notice: Undefined index: module i _field_info_prepare_instance_widget() (rad 382 av /srv/www/231/web/modules/field/field.info.inc).
    Notice: Undefined index: module i _field_info_prepare_instance_display() (rad 350 av /srv/www/231/web/modules/field/field.info.inc).
    Notice: Undefined index: module i _field_info_prepare_instance_display() (rad 350 av /srv/www/231/web/modules/field/field.info.inc).
    Notice: Undefined index: module i _field_info_prepare_instance_widget() (rad 382 av /srv/www/231/web/modules/field/field.info.inc).
    Notice: Undefined index: module i _field_info_prepare_instance_display() (rad 350 av /srv/www/231/web/modules/field/field.info.inc).
    Notice: Undefined index: module i _field_info_prepare_instance_display() (rad 350 av /srv/www/231/web/modules/field/field.info.inc).
    Notice: Undefined index: module i _field_info_prepare_instance_widget() (rad 382 av /srv/www/231/web/modules/field/field.info.inc).
    Notice: Undefined index: module i _field_info_prepare_instance_display() (rad 350 av /srv/www/231/web/modules/field/field.info.inc).
    Notice: Undefined index: module i _field_info_prepare_instance_display() (rad 350 av /srv/www/231/web/modules/field/field.info.inc).
    Notice: Undefined index: module i _field_info_prepare_instance_widget() (rad 382 av /srv/www/231/web/modules/field/field.info.inc).
    Notice: Undefined index: module i _field_info_prepare_instance_display() (rad 350 av /srv/www/231/web/modules/field/field.info.inc).
    Notice: Undefined index: module i _field_info_prepare_instance_display() (rad 350 av /srv/www/231/web/modules/field/field.info.inc).
    Notice: Undefined index: module i _field_info_prepare_instance_widget() (rad 382 av /srv/www/231/web/modules/field/field.info.inc).
    Notice: Undefined index: module i _field_info_prepare_instance_display() (rad 350 av /srv/www/231/web/modules/field/field.info.inc).
    Notice: Undefined index: module i _field_info_prepare_instance_display() (rad 350 av /srv/www/231/web/modules/field/field.info.inc).
    Notice: Undefined index: module i _field_info_prepare_instance_widget() (rad 382 av /srv/www/231/web/modules/field/field.info.inc).
    Notice: Undefined index: module i _field_info_prepare_instance_display() (rad 350 av /srv/www/231/web/modules/field/field.info.inc).
    Notice: Undefined index: module i _field_info_prepare_instance_widget() (rad 382 av /srv/www/231/web/modules/field/field.info.inc).
    Notice: Undefined index: module i _field_info_prepare_instance_display() (rad 350 av /srv/www/231/web/modules/field/field.info.inc).
    Notice: Undefined index: module i _field_info_prepare_instance_widget() (rad 382 av /srv/www/231/web/modules/field/field.info.inc).
    Notice: Undefined index: module i _field_info_prepare_instance_display() (rad 350 av /srv/www/231/web/modules/field/field.info.inc).
    Notice: Undefined index: module i _field_info_prepare_instance_widget() (rad 382 av /srv/www/231/web/modules/field/field.info.inc).
    Notice: Undefined index: module i _field_info_prepare_instance_display() (rad 350 av /srv/www/231/web/modules/field/field.info.inc).
    Notice: Undefined index: module i _field_info_prepare_instance_widget() (rad 382 av /srv/www/231/web/modules/field/field.info.inc).
    Notice: Undefined index: module i _field_info_prepare_instance_display() (rad 350 av /srv/www/231/web/modules/field/field.info.inc).
    Notice: Undefined index: module i _field_info_prepare_instance_display() (rad 350 av /srv/www/231/web/modules/field/field.info.inc).
    Notice: Undefined index: module i _field_info_prepare_instance_widget() (rad 382 av /srv/www/231/web/modules/field/field.info.inc).
    Notice: Undefined index: module i _field_info_prepare_instance_display() (rad 350 av /srv/www/231/web/modules/field/field.info.inc).
    Notice: Undefined index: module i _field_info_prepare_instance_display() (rad 350 av /srv/www/231/web/modules/field/field.info.inc).
    Notice: Undefined index: module i _field_info_prepare_instance_widget() (rad 382 av /srv/www/231/web/modules/field/field.info.inc).
    Notice: Undefined index: module i _field_info_prepare_instance_display() (rad 350 av /srv/www/231/web/modules/field/field.info.inc).
    Notice: Undefined index: module i _field_info_prepare_instance_display() (rad 350 av /srv/www/231/web/modules/field/field.info.inc).
    Notice: Undefined index: module i _field_info_prepare_instance_widget() (rad 382 av /srv/www/231/web/modules/field/field.info.inc).
    Notice: Undefined index: module i _field_info_prepare_instance_display() (rad 350 av /srv/www/231/web/modules/field/field.info.inc).
    Notice: Undefined index: module i _field_info_prepare_instance_display() (rad 350 av /srv/www/231/web/modules/field/field.info.inc).
    Notice: Undefined index: module i _field_info_prepare_instance_widget() (rad 382 av /srv/www/231/web/modules/field/field.info.inc).
    Notice: Undefined index: module i _field_info_prepare_instance_display() (rad 350 av /srv/www/231/web/modules/field/field.info.inc).
    Notice: Undefined index: module i _field_info_prepare_instance_display() (rad 350 av /srv/www/231/web/modules/field/field.info.inc).
    Notice: Undefined index: module i _field_info_prepare_instance_widget() (rad 382 av /srv/www/231/web/modules/field/field.info.inc).
    Notice: Undefined index: module i _field_info_prepare_instance_display() (rad 350 av /srv/www/231/web/modules/field/field.info.inc).
    Notice: Undefined index: module i _field_info_prepare_instance_widget() (rad 382 av /srv/www/231/web/modules/field/field.info.inc).
    Notice: Undefined index: module i _field_info_prepare_instance_display() (rad 350 av /srv/www/231/web/modules/field/field.info.inc).
    Notice: Undefined index: module i _field_info_prepare_instance_widget() (rad 382 av /srv/www/231/web/modules/field/field.info.inc).
    Notice: Undefined index: module i _field_info_prepare_instance_display() (rad 350 av /srv/www/231/web/modules/field/field.info.inc).
    Notice: Undefined index: module i _field_info_prepare_instance_widget() (rad 382 av /srv/www/231/web/modules/field/field.info.inc).
    Notice: Undefined index: module i _field_info_prepare_instance_display() (rad 350 av /srv/www/231/web/modules/field/field.info.inc).
    Notice: Undefined index: node_reference i field_ui_field_overview_form() (rad 364 av /srv/www/231/web/modules/field_ui/field_ui.admin.inc).
    Notice: Undefined index: i field_ui_field_overview_form() (rad 370 av /srv/www/231/web/modules/field_ui/field_ui.admin.inc).
    Notice: Undefined index: node_reference i field_ui_field_overview_form() (rad 364 av /srv/www/231/web/modules/field_ui/field_ui.admin.inc).
    Notice: Undefined index: i field_ui_field_overview_form() (rad 370 av /srv/www/231/web/modules/field_ui/field_ui.admin.inc).
    Notice: Undefined index: node_reference i field_ui_existing_field_options() (rad 1503 av /srv/www/231/web/modules/field_ui/field_ui.admin.inc).
    Notice: Undefined index: node_reference i field_ui_existing_field_options() (rad 1503 av /srv/www/231/web/modules/field_ui/field_ui.admin.inc).
    Notice: Undefined index: node_reference i field_ui_existing_field_options() (rad 1503 av /srv/www/231/web/modules/field_ui/field_ui.admin.inc).
    Notice: Undefined index: node_reference i field_ui_existing_field_options() (rad 1503 av /srv/www/231/web/modules/field_ui/field_ui.admin.inc).
    Notice: Undefined index: user_reference i field_ui_existing_field_options() (rad 1503 av /srv/www/231/web/modules/field_ui/field_ui.admin.inc).
    Notice: Undefined index: node_reference i field_ui_existing_field_options() (rad 1503 av /srv/www/231/web/modules/field_ui/field_ui.admin.inc).
    Notice: Undefined index: node_reference i field_ui_existing_field_options() (rad 1503 av /srv/www/231/web/modules/field_ui/field_ui.admin.inc).
pontus_nilsson’s picture

pontus_nilsson
Location Stockholm
commented

Ohh... I didn't have references installed. No wonder why these errors.

john morahan’s picture

john morahan commented
Status: Fixed » Needs review
StatusFileSize
new 1295276.patch690 bytes

I think something went wrong with this commit as there are a couple of '+' characters missing from the regular expression, though they are present in the patch.

Attached patch restores them.

perarnet’s picture

perarnet commented
StatusFileSize
new entityreferences_views_1295276_9.patch3.52 KB

I got some more problems with integrating with entityreferences and views. This fixes the warnings, and lets you select a default view in field settings. Also need to use patch in http://drupal.org/node/1253776#comment-5301980

perarnet’s picture

perarnet commented
StatusFileSize
new entityreferences_views_1295276_10.patch.txt1.58 KB

Added wrong patch, here is a stripped version

john morahan’s picture

john morahan commented

Hmm I would have thought that sort of thing was what the type_callback was for? as target_type is kinda specific to entityreference, isn't it?

john morahan’s picture

john morahan commented
StatusFileSize
new 1295276.patch2.88 KB

Like this for example (also including my regex patch from above).

fabsor’s picture

fabsor commented
Status: Needs review » Fixed

Thanks, I missed that this didn't work properly. I Commited the last patch.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

lsolesen’s picture

lsolesen commented

Maybe the module page should be updated, so people know the module also supports entity reference.

mxt’s picture

mxt
Primary language Italian
Location Milan
commented

Please, give us here http://drupal.org/node/1478826 some information on the steps we have to follow to use reference dialog in conjunction with entity reference

Thank you!

finex’s picture

finex commented

I agree with @isolesen, if references dialog module works with entity reference it should be written on the module description.

Thanks

yogaf’s picture

yogaf commented

I agree with @FiNeX and @isolesen, It's not clear from the module description.
Almost missed it.

trumanru’s picture

trumanru commented

#15
Posted by lsolesen on February 13, 2012 at 1:02pm

Maybe the module page should be updated, so people know the module also supports entity reference.

Vote for this.

lsolesen’s picture

lsolesen commented
Category: feature » task
Status: Closed (fixed) » Active
liquidcms’s picture

liquidcms commented

yes, project page should be updated - i originally passed over this module as a solution as the project page seemed to suggest it would only work with user/node references and not entityrefs.

hefox’s picture

hefox commented

Having this as an open/active ticket with this title is probably even more misleading then not having the project page updated. Perhaps re-close this and open a new issue about updating the project page?

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Category: task » feature
Status: Active » Closed (fixed)

I opened a new issue to cover the project page updates: #2019211: Update the project page