Posted by pillarsdotnet on September 30, 2011 at 4:06am
3 followers
| Project: | Drupal core |
| Version: | 8.x-dev |
| Component: | documentation |
| Category: | bug report |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | closed (fixed) |
| Issue tags: | needs backport to D7 |
Issue Summary
Attached one-line patch fixes what I am sure is a simple typographical error:
--- a/includes/theme.inc
+++ b/includes/theme.inc
@@ -275,7 +275,7 @@ function _theme_registry_callback($callback = NULL, array $argume
* @param $base_theme
* An array of loaded $theme objects representing the ancestor themes in
* oldest first order.
- * @param theme_engine
+ * @param $theme_engine
* The name of the theme engine.
*/
function _theme_load_registry($theme, $base_theme = NULL, $theme_engine = NULL) {
Comments
#1
Found another one in _theme_build_registry:
@@ -519,7 +519,7 @@ function _theme_process_registry(&$cache, $name, $type, $theme, $path) {* @param $base_theme
* An array of loaded $theme objects representing the ancestor themes in
* oldest first order.
- * @param theme_engine
+ * @param $theme_engine
* The name of the theme engine.
*/
function _theme_build_registry($theme, $base_theme, $theme_engine) {
Attaching the patch for real this time.
#2
Yes, this needs to be done.
#3
Tagging for backport to D7. Applies cleanly to D7 and D8.
#4
For now...
#5
Well, yes. It's always a moving target. Sometimes moving more than usual :-)
#6
Committed and pushed to 8.x and 7.x. Thanks!
For future reference, I'm fine with patches like these being all combined into one. It makes reviewing and committing easier.
#7
Automatically closed -- issue fixed for 2 weeks with no activity.