Arguments to theme as renderable array in a render array. Allow better nesting of html element.

s/by of/,/

On second thought, it would be better if I can have,

 'title' => Array (BLEH BLAH UGH),

rendered first then have it converted to,

 '#title' => HTML-MARKUP,

somehow. :S

This is for #theme whose arguments expect simple text or predefined html markup.

I came up with:

function drupal_pre_render_map_childs($element) {
  foreach ($element['#map_childs'] as $key => $values) {
    // We expected $values to be an array.
    $element[$key] = drupal_render_children($element, $values);
  }
  return $element;
}

Basically it merges several children listed in $values part of #map_childs into a single key. Presumable, like in the sample below, points to #text, an argument that goes to theme_link.

Implemented here.

// Implement hook_block_view
function MYMODULE_block_view($delta = '') {
  $block = array();

  switch ($delta) {
    case 'external_links':
      $block['subject'] = t('External Links');
      $block['content'] = array(
        'one_linky' => array(

          '#pre_render' => array('drupal_pre_render_map_childs'),
          '#map_childs' => array(
            // Render title and store the result in #text.
            '#text' => array('title'),
          ),

          '#theme' => 'link',
          '#path' => 'http://MYLINKBLAH',
          '#options' => array(
            'attributes' => array(),
            'html' => TRUE,
          ),
          // Normally we expect #text to be defined here, and its
          // value can only be either plain text (or literal string) or html.

          'title' => array(
            '#theme' => 'image',
            '#path' => 'http://MYIMAGEBLAH',
          ),

        ),
      );
      break;
  }
  return $block;
}

Doesn't work with #type such as '#type' => 'link' because the #pre_render clashed. I think. Dunno.

So it's fine if we just use '#theme' => 'link'.

PS: I see similar applications in drupal_pre_render_links.

Changed title and marked as need review.

Also served as snippet page, if anybody is interested. :3

Failed at theme_links() XD. Bummer.

The following code works, with a little exception.

function drupal_pre_render_map_childs($element) {
  foreach ($element['#map_childs'] as $key => $value) {
    if (is_array($value)) {
      $element[$key] = drupal_render_children($element, $value);
    }
    else {
      drupal_render_children($element[$value]);
      $element[$key] = $element[$value];
    }
  }
  return $element;
}

The change is, for theme function that expects the argument to be an array, #map_childs' value has to be a string, not array. This tells drupal_pre_render_map_childs not to set the argument with results from drupal_render_children(), but link it by reference to $element[$value], thus result in an array that we wanted.

Example follows.

$markup = array(
  '#pre_render' => array('drupal_pre_render_map_childs'),
  '#map_childs' => array(
    '#links' => 'my_links',
  ),
  '#theme_wrappers' => array('container'),
  '#attributes' => array(),
  '#theme' => 'links',
  'my_links' => array(
    'first_link' => array(
      'href' => 'http://MYLINKBLAH/',
      'html' => '1',
      '#pre_render' => array('drupal_pre_render_map_childs'),
      '#map_childs' => array(
        'title' => array('my_image'),
      ),
      'my_image' => array(
        '#theme' => 'image',
        '#path' => 'http://MYLINKBLAH/MYIMAGE.jpg',
      ),
    ),
  ),
);

Notice that html value is '1' (a string). Either wise that element is passed to element_children() and produce warnings.

Warning: Invalid argument supplied for foreach() in element_children()

Ugly as hell, but in my use case, it works. 0.0b

PS: set html to value '1' or '0' works as if it is set with TRUE and FALSE. Me need to spent more time debugging. This could replace drupal_pre_render_links() with a bit more functionality.

Simple fix, modified drupal_render() in includes/common.inc, before:

  // Early-return nothing if user does not have access.
  if (empty($elements) || (isset($elements['#access']) && !$elements['#access'])) {
    return;
  }

And after:

  // Early-return nothing if user does not have access.
  if (!is_array($elements) || (isset($elements['#access']) && !$elements['#access'])) {
    return;
  }

Maybe I should add !count($elements) in there. Hm.

First attempt on OnionHead _failed_.

In case somebody is waiting for this to hit need review ~(‾-‾")~, forgotten to mark the patch listed, no changes made.

Reduce possible hick-up to one.

That is if the theme function requires 2 or more level-deep array-argument.

Might become a problem since drupal_render_children automatically adds #printed and #children element.

This two elements can be an unexpected baggage in the theme function.

#6: argument_totheme_asrenderarray.patch queued for re-testing.

A quick note:

This function uses iteration, can cause deep iteration if the render array is nested too deep.

PHP is not optimized to do iteration, I think.

Unless, drupal uses SPL iterators, then this might just work for the general cases.

I'll try to find the link where I've read that, in stackoverflow.com IIRC.

Closed as works as designed I guess, to be removed from the issue queue active priority.

heh. s/of//