Closed (won't fix)
Project:
Formfilter
Version:
5.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
21 Mar 2007 at 03:11 UTC
Updated:
2 Mar 2012 at 18:15 UTC
Jump to comment: Most recent file
Comments
Comment #1
JohnG-1 commented+1 this makes sense to me.
Comment #2
nedjoI don't fully understand the suggested changes. Can you explain more? What doesn't persist at present? What would persist?
I believe there is the ability to make the filtering apply to all users (except UID 1)--just don't give any users the permission to view forms without filtering.
Comment #3
JohnG-1 commentedApologies to you nedjo for sloppy testing on my part:
I hadn't realised that the form filter settings automatically 'save' themselves, and by default the filtered form is not shown to Admin (user/1)
... so I couldn't understand how to get the formfilters to stick ;P
Perhaps we could start work on a little light documentation ;)
Comment #4
nedjoPoint taken :) And, hey, anything you might want to post to that effect would be very welcome.
Comment #5
JohnG-1 commentedHow about this little description, which could be used on the project homepage (drupal.org/project/formfilter):
"
"
(Nb - the Preview link should (in a perfect world) disappear when no filters are active, ie if all the 'Hide ...' checkboxes are unselected.)
... I still find the 'Submit' method for the filter checkbox settings rather un-intuitive. For example, I'm testing it on a node-create form, which requires a node Title at least, so if I use the Preview or Submit buttons (without entering a title because I don't actually want to create a node), I get stalled and distracted by the formcheck error message. The filters get applied OK, but the UI/workflow becomes confusing.
Does that make sense ?
Comment #6
JohnG-1 commented@ #5.2 : Hang on ... even simpler solution:
Because the Form's Formfilter-edit page settings are applied when a checkbox is altered (we don't need to submit the changes), all we need to do is add the Preview a filtered version of this form link to the bottom of that page ... just to give Admins somewhere to go next ...?
Comment #7
nedjoThanks a lot for the suggested text, I've updated the module description.
Your other suggestions are good. I'll have to think a bit about how I could implement them, and I'm busy with other things, but if I find time I'll try to make improvements. Of course, if anyone wants to submit patches that would be great.
Comment #8
JohnG-1 commented@ #5 : add the Preview a filtered version of this form link to the bottom of the Form's Formfilter-edit page. This seems easy enough but unfortunately when the link is clicked, it doesn't 'save' the changes; getting the link to behave as a Submit button is apparently necessary :P ... I've been staring at this for hours and I just don't understand enough code to see how to do this ... ?
The attached patch simply reproduces the Preview link generator in the 'edit' bit of
function formfilter_form_alter. Part way there at least ;)Comment #9
pianomansam commentedCleaning up old issues. D5 release is no longer supported. Please direct feature requests to D6 release.