The ec_file module has a couple of relatively tenuous links into the ec_recurring module (one of which is a direct table join; not API call) that it seems to me could be entirely optional and hence would remove the dependence of ec_file on ec_recurring.

My reasoning is:

  1. I have no need for the ec_recurring module at the moment but wish to use ec_file. It seems overkill to enable ec_recurring to get ec_file to work.
  2. The dependence sems to be very light and could easily be coded to be optional.
  3. The ec_file module is an optional core module depending on a contributed module (perhaps that is destined to change?)

Anyway, just a suggestion. There may be reasons for the dependence (future plans, etc) that I am not privy too.

Am happy to make the change if others like the idea.

Comments

skelly’s picture

skelly commented
Title: Remove ec_recurring dependency? » Remove ec_recurring dependency from ec_file?
gordon’s picture

gordon commented

The reason that there is a dependency is that you can sell files that expire after a while.

skelly’s picture

skelly commented

Hi Gordon,

Thanks for the response and congrats on the great progress with e-commerce recently.

I appreciate what you are saying and why the dependency is there for that reason. All I was suggesting was that there may be instances where the expiry functionality is not required (such as my own) and since ec_file seems to only depend lightly on ec_recurring then it would seem relatively harmless to make the dependency optional. I.e. Make ec_file work without or with the ec_recurring module with a few simple "module exists" tests.

Anyway, not a biggy.

Cheers,

Scott

davea’s picture

davea commented
Status: Active » Closed (fixed)

no longer supported- Sorry!