The module does not work with Drupal HEAD. Going to the settings page, gives you an 'access denied' error.
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | paypal_tipjar.module | 9.8 KB | carlmcdade |
| #2 | paypal_tipjar.patch | 13.79 KB | carlmcdade |
The module does not work with Drupal HEAD. Going to the settings page, gives you an 'access denied' error.
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | paypal_tipjar.module | 9.8 KB | carlmcdade |
| #2 | paypal_tipjar.patch | 13.79 KB | carlmcdade |
Comments
Comment #1
inteja commentedSame problem here.
Comment #2
carlmcdade commentedI have fixed the permissions problem and one other problem in the imagepng() code. Here's a patch. Test with 4.5.2
Comment #3
carlmcdade commentedThe entire code for windows users and non programmers
Comment #4
baudolino commentedI've just tested the latest cvs version (1.6) of this module with Drupal 4.6.0 and so far I can't see any problems.
Also, the patch provided above seems to be obsolete, as it looks like version 1.6 of this module incorporated all proposed changes.
I guess someone in charge can mark this bug report as fixed/closed and, after further testing, tag the module as compatible with Drupal 4.6.0
Comment #5
sleepytim commentedWould somebody remove the paypal/validate URL in the comment section of paypal_tipjar.module ? That caused a few hours of confusion on my side. It'd be nice if it points to paypal_framework.module.
Thanks,
Tim
Comment #6
sleepytim commentedThe use of (float) to convert the color codes does not appear to be correct. Replace the (float) instances with hexdec().
I also added this line to draw the target amount at the center of the graph which I think looks better.
$center = ($image->width - imagefontwidth(1) * (strlen($target_level)+1)) / 2;
if ($center < 0) { $center = 0; }
then use $center as the x coordinate for drawing the string.
Tim
Comment #7
njivy commentedAs you mentioned in the other thread, the documentation and hexdec() issues have been fixed as suggested. Thanks.
Comment #8
(not verified) commented