Hi, I found this module very useful !
Why not integrate it with the core watchdog ? I mean, on .../admin/reports/hits there are the following columns: Timestamp, Page, User and Operations --> User could be merged with additional info coming from IP Lookup.
What do you think ?

Comments

helmo’s picture

helmo commented

You might be able to do this with a theme function that rewrites the ip as a link to the whois lookup page.

But don't over estimate the value of whois information for an IP. It just gives you the owner of the IP range the user is coming from.

mandreato’s picture

mandreato commented

Thank you helmo for the reply !
It could be something like #22494: Add IP lookup capabilities to the watchdog module...

I know that whois info is not so much detailed, but it would be very useful as well: for example, when Google crawlers are analyzing the website, it is very difficult to distinguish them from real visitors because the log reports "anonymous" in every case.
Instead a short info on provider name would clarify immediately who is in.

helmo’s picture

helmo commented

Would be really cool if we could 'solve' that issue...

I had a look with devel_themer, but it didn't have a good hit to a usable theme function.

The hint about hook_menu_alter() would require wrapping around statistics_access_log() and modifying the render array.

Find the 'Hostname' row in $build['statistics_table']['#rows'] and rewrite it as a link to /whois/%s

But there has to be a nicer way to interact with this render array,

mandreato’s picture

mandreato commented

What about this #381802: Have theme_username() show hostname for anonymous users if available ?

helmo’s picture

helmo commented

I think I agree with Dries's remark in http://drupal.org/node/381802#comment-1299522

theme_username should not be called in this case, and we would need something like theme_hostname()

helmo’s picture

helmo commented
Status: Active » Postponed (maintainer needs more info)

Postponing this as I don't see a clean way to this this without hacking core...

gpk’s picture

gpk commented
Status: Postponed (maintainer needs more info) » Active

http://drupal.org/project/views_watchdog and a Views ?formatter perhaps? Wld be good to have a reverse DNS option as well but maybe doesn't belong here.

helmo’s picture

helmo commented

gpk: would you be able to provide a patch for that?
I'd be happy to include it.

helmo’s picture

helmo commented
Status: Active » Postponed (maintainer needs more info)