Drop remnants of #node_edit_form [#1297410]

Comment	File	Size	Author
#25	1297410-25.patch	1.78 KB	bfroehle
#20	remove_pound_node_edit_form-1297410.patch	1.4 KB	bfroehle
#17	drop-remnants-of-node-edit-form-1297410-16.patch	1.2 KB	bhosmer
#15	drop-remnants-of-node-edit-form-1297410-8.patch	1.66 KB	bhosmer
#13	drop-remnants-of-node-edit-form-1297410-8.patch	1.7 KB	bhosmer
#12	drop-remnants-of-node-edit-form-1297410-8.patch	1.7 KB	bhosmer
#10	drop-remnants-of-node-edit-form-1297410-8.patch	1.2 KB	bhosmer
#5	drop-remnants-of-node-edit-for-1297410-1.patch	547 bytes	bhosmer
#1	drop-remnants-of-node-edit-for-1297410-1.patch	546 bytes	bhosmer

Comment #1

bhosmer commented 15 October 2011 at 02:03

Status	File	Size
new	drop-remnants-of-node-edit-for-1297410-1.patch	546 bytes

Well, here goes my first try at contributing a patch to core.

Log in or register to post comments

Comment #2

bhosmer commented 15 October 2011 at 02:03

Assigned:

Unassigned

» bhosmer

Log in or register to post comments

Comment #3

bhosmer commented 15 October 2011 at 02:03

Status:

Active

» Needs review

Log in or register to post comments

Comment #4

15 October 2011 at 02:05

Status:

Needs review

» Needs work

The last submitted patch, drop-remnants-of-node-edit-for-1297410-1.patch, failed testing.

Log in or register to post comments

Comment #5

bhosmer commented 15 October 2011 at 02:07

Status:

Needs work

» Needs review

Status	File	Size
new	drop-remnants-of-node-edit-for-1297410-1.patch	547 bytes

Log in or register to post comments

Comment #6

sun

German

Karlsruhe

commented 15 October 2011 at 02:30

Status:

Needs review

» Needs work

+++ b/modules/node/node.pages.inc
@@ -107,8 +107,7 @@ function node_form($form, &$form_state, $node) {
   // Identify this as a node edit form.
-  // @todo D8: Remove. Modules can implement hook_form_BASE_FORM_ID_alter() now.
-  $form['#node_edit_form'] = TRUE;
+  $form_state['build_info']['base_form_id'] == 'node_form';

The removals are OK, but should actually include the comment.

And the new condition actually needs to be used wherever #node_edit_form is currently used throughout core. (most likely, in tests only)

-13 days to next Drupal core point release.

Log in or register to post comments

Comment #7

bhosmer commented 15 October 2011 at 09:44

From looking at the simpletest, I see it was also used in the forum. module too.

What comment are you referring to that still needs to be included?

The removals are OK, but should actually include the comment.

Log in or register to post comments

Comment #8

sun

German

Karlsruhe

commented 15 October 2011 at 14:27

The chunk of lines you touched in node_form() can be removed entirely; i.e., including the comment, and without replacement.

Log in or register to post comments

Comment #9

bhosmer commented 16 October 2011 at 01:03

Cool. Thanks.

Now, what about forum.module:

if (!empty($form['node_form']) && isset($form['taxonomy_forums'])) {
    $langcode = $form['taxonomy_forums']['#language'];
    // Make the vocabulary required for 'real' forum-nodes.
    $form['taxonomy_forums'][$langcode]['#required'] = TRUE;
    $form['taxonomy_forums'][$langcode]['#multiple'] = FALSE;
    if (empty($form['taxonomy_forums'][$langcode]['#default_value'])) {
      // If there is no default forum already selected, try to get the forum
      // ID from the URL (e.g., if we are on a page like node/add/forum/2, we
      // expect "2" to be the ID of the forum that was requested).
      $requested_forum_id = arg(3);
      $form['taxonomy_forums'][$langcode]['#default_value'] = is_numeric($requested_forum_id) ? $requested_forum_id : '';
    }
  }
}

I assume this entire function can be removed or not?