if css optimization is on CSS files of elfinder is not included

Patch in elfinder.module with renamed css from sites/all/modules/elfinder/css/elfinder.css to elfinder.common.css because it replaces the library css:

$options = array('group' => CSS_DEFAULT, 'every_page' => FALSE);
drupal_add_css($libpath . '/css/smoothness/jquery-ui-1.8.13.custom.css', $options);
drupal_add_css($libpath . '/css/elfinder.css', $options);
drupal_add_css($path . '/css/elfinder.common.css', $options);

if (VERSION == 7) {
drupal_add_css($path . '/css/elfinder.d7.css', $options);
}

Comments

ph0enix’s picture

ph0enix commented

Thanks for patching!

I have added this patch with some modifications to dev branch.

ph0enix’s picture

ph0enix commented
Status: Patch (to be ported) » Needs review
polskikrol’s picture

polskikrol commented
Version: 7.x-0.6 » 7.x-1.x-dev
Status: Needs review » Active

Looks like with the 7.x-1.x-dev branch from Dec 30th, this issue is re-occurring.

Noticed that css/elfinder.drupal.css was replaced with 2 new files:

elfinder.css
elfinder.d7.css

I have already tried clearing all caches and the only fix is to disable "Aggregate and compress CSS files." under Performance :[

polskikrol’s picture

polskikrol commented

As a quick fix, copied back the old CSS file and modified the following in elfinder.module:

elfinder_add_css($libpath . '/css/elfinder.css', $options);
// elfinder_add_css($path . '/css/elfinder.css', $options);
elfinder_add_css($path . '/css/elfinder.drupal.css', $options);

/* Adding D7 frontend style fixes */
// if (VERSION == 7) {
// elfinder_add_css($path . '/css/elfinder.d7.css', $options);
// }

Any reason why there is non-Drupal 7 code within a module marked as version 7? Perhaps this can be cleaned up with all if statements looking for module version other than Drupal 7 removed? Should this be opened as a new bug report?

polskikrol’s picture

polskikrol commented
Status: Active » Needs review

Looks like this issue is fixed in 7.x-1.x-dev (2012-Jan-05).

ph0enix’s picture

ph0enix commented
Status: Needs review » Closed (fixed)