Closed (outdated)
Project:
Drupal core
Version:
main
Component:
comment.module
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
21 Mar 2007 at 16:22 UTC
Updated:
17 Mar 2026 at 18:12 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
ax commentedpatch didn't apply - here is the real one.
Comment #2
gerhard killesreiter commentedthat's IMO a feature and thea means it can only get into Druapl 6.
Comment #3
ax commentedhm - was afraid of that :(. well then, here we go. first a patch for 5.x ...
Comment #4
ax commented... and here the one for 6.x.
Comment #5
Anonymous (not verified) commentedSubscribing.
May be nice if we were able to assign the user automagicly via email address. I'll set a todo for myself for that.
Comment #6
ax commentedspeaking of "may be nice": it would also be nice if this (alternatively) could be done as a mass-op on comments, ie. assign all selected comments in admin/comment to a certain user. unfortunately, my todo-list is too long already :(
Comment #7
dries commentedThis functionality looks good.
What is the second chunk for? Is that intentional?
Comment #8
ax commentedthat second chunk is intentional, yes. by adding the 'author' autocomplete form field for assigning a registered user, we always have that value in the request, even if we leave the field empty (which is the default, as the comment administration fieldset is collapsed by default). so we cannot check with isset() anymore.
i attach a screenshot, maybe this makes things clearer. note that the 'author' field is 'Assign to user:' - not 'Authored by:', this is 'name', as it is the name of an anonymous commenter and not a registered user.
Comment #9
ax commentedthat second chunk is intentional, yes. by adding the 'author' autocomplete form field for assigning a registered user, we always have that value in the request, even if we leave the field empty (which is the default, as the comment administration fieldset is collapsed by default). so we cannot check with isset() anymore.
i attach a screenshot, maybe this makes things clearer. note that the 'author' field is 'Assign to user:' - not 'Authored by:', this is 'name', as it is the name of an anonymous commenter and not a registered user.
Comment #10
ax commentedthat second chunk is intentional, yes. by adding the 'author' autocomplete form field for assigning a registered user, we always have that value in the request, even if we leave the field empty (which is the default, as the comment administration fieldset is collapsed by default). so we cannot check with isset() anymore.
i attach a screenshot, maybe this makes things clearer. note that the 'author' field is 'Assign to user:' - not 'Authored by:', this is 'name', as it is the name of an anonymous commenter and not a registered user.
Comment #11
ax commentedthat second chunk is intentional, yes. by adding the 'author' autocomplete form field for assigning a registered user, we always have that value in the request, even if we leave the field empty (which is the default, as the comment administration fieldset is collapsed by default). so we cannot check with isset() anymore.
i attach a screenshot, maybe this makes things clearer. note that the 'author' field is 'Assign to user:' - not 'Authored by:', this is 'name', as it is the name of an anonymous commenter and not a registered user.
Comment #12
ax commentedsorry for double-double-posting. there were server errors, and apparently i pressed the reload button 3 times too often. any way do delete comments to issues?
Comment #13
dries commentedThe UI looks a bit awkward to me. It might look better if the 'assigned to user' would be shown in a block next to the anonymous user stuff. Not quite sure.
The functionality is really useful, but I'd like to hear other people's ideas about this, and the UI in particular.
Comment #14
ax commentedlike that (attached screenshot)?
Comment #15
yngens commentedsubscribe
Comment #16
dries commentedax: that looks somewhat nicer, yes! :)
Comment #17
ax commentedanother ui option: put the "assign to user" (which probably won't get used much) in a collapsed fieldset. see attached screenshot 1 ...
Comment #18
ax commented... and 2.
Comment #19
sutharsan commentedI agree that this is a desired functionality to be able to change/add the author.
However the interface confuses me. If the comment is by a anonymous the 'Authored by' field is empty. Now I have two options to enter a name, 'Authored by' and 'Assign to user'. I would rather see here only one field in which to enter the name or change an existing name.
Comment #20
ax commented@Sutharsan:
the 'Authored by' field only is empty if you don't allow anonymous users to enter a name (admin/content/comment/settings). otherwise, the name they entered when submitting the comment appears.
regarding "now i have two options to enter a name, 'Authored by' and 'Assign to user'": thats why i made my second ui suggestion (#17 above) which by default hides the 'Assign to (registered) user'. would that be better?
Comment #21
ax commentedoops - just noticed that the last 2 screenshots have a problem with the form elements weights. of course the 'Assign to registered user' must be directly below 'Authored by'. new shot attached.
Comment #22
ax commentedto make things even more clear, clearly name 'anonymous' and 'registered' user fields and provide some explanation. next screenshot, with the 'Assign to registered user' fieldset expanded.
Comment #23
sutharsan commented#22 is much better, thanks.
Comment #24
ax commentednew patch for UI and CVS changes
Comment #25
catchNo longer applies, moving this to D7 queue.
Comment #26
yngens commentedApplying patch for 5.x in #3 gives:
[root@host comment]# patch *.patch
(Stripping trailing CRs from patch.)
patching file comment_db_rewrite_sql_backport5.patch
Hunk #1 FAILED at 1483.
Hunk #2 FAILED at 1649.
2 out of 2 hunks FAILED -- saving rejects to file comment_db_rewrite_sql_backport5.patch.rej
[root@host comment]#
I see this moved to 7.x, but will it also work for 5.x some day?
Comment #27
elitefox commentedSorry I am new to patch thing :)
How do apply this patch?
I have drupal 6.9 running on my machine and maybe planning to upgrade to 6.10 and if that happens will I need to apply the patch again?
Best Regards,
elitefox
Comment #28
ax commentedplease don't change versions just because *you* happen to run a specific one. thanks!
Comment #29
Anonymous (not verified) commented@elitefox: This is a support question. See http://drupal.org/support for where to ask or at least http://www.google.com/search?q=apply+patch+file.
Comment #30
bsherwood commented+1 on adding this feature to 7.x.
I think the whole "assign to registered user" bit is unnecessary. When an admin edits a node we just use the "authored by" autocomplete field to change the creator. Can't we just make the "Authored by" field act the same way as the node/*/edit form?
Comment #31
elitefox commented@ax
Sorry that was my first post, thought my drupal core version is needed to be stated =)
hope you will forgive me :(
Comment #32
rmjiv commentedSubscribing
Comment #33
pcs305 commentedHere's a patch for 6.17 if anyone is interested. Not a patch from CVS.
YMMV, It works for me. I'm slowly working on 7 but hope someone will beat me to it ;)
Comment #34
yngens commentedError on applying the last patch:
Parse error: syntax error, unexpected '}', expecting ']' in /usr/drupal/drupal6/modules/comment/comment.module on line 1204Comment #35
pcs305 commentedFixed the problem.
Thanks
Comment #36
yngens commentedNow it works correctly, thanks. The only caveat is that if you set "Anonymous posters must leave their contact information" then it still spits out name required notice and you can not assign anonymous comment to a registered user. The option in comment settings for a content type should be different than "must leave".
Comment #37
yngens commentedI hope this one will be committed to the core.
Comment #38
bsherwood commentedMoving to 8.x
Comment #39
yngens commentedI believe one of these two nodes should be marked as duplicate to concentrate all the efforts to solve the issue at one place:
#936844: Cannot override comment author to or from Anonymous Posted by skyredwang on October 9, 2010 at 8:04am and has 21 comments to the moment
#129822: allow admins to assign anonymous comments to registered users Posted by ax on March 21, 2007 at 8:22am and has 38 comments to the moment
Comment #40
greenreaperI got around the "must leave contact information" problem by adding the condition !$edit['author'] to the following else if:
This might not be the right way to do it . . .
Comment #41
JoshOrndorff commentedI would love to see this functionality added to core. In the meantime, does anyone know of a module to do it?
-Josh
Comment #42
andypostComment #58
smustgrave commentedThank you for sharing your idea for improving Drupal.
We are working to decide if this proposal meets the Criteria for evaluating proposed changes. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or there is no community support. Your thoughts on this will allow a decision to be made.
Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.
Thanks!
Comment #59
smustgrave commentedWanted to bump this 1 more time before closing.
Comment #61
smustgrave commentedSince it's been 11 years without movement or interest. And was a feature request going to close out. Can always be closed out.