Tracking numbers should not show up in order info when there is no tracking info

CommentFileSizeAuthor
tracking.patch415 bytesbwynants

Comments

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Needs review » Fixed

Committed, with changes to avoid an undefined variable error if the pane is to be hidden.

tr’s picture

tr commented
Status: Fixed » Needs work

So now there's no way for the administrator to see and notice that the tracking number has not yet been entered? There's definitely a need to keep the tracking number block visible when it's empty. If you want the tracking number block hidden because you're not using tracking numbers, then just turn off the pane at admin/store/settings/orders.

I vote for reverting this patch.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Needs work » Fixed

Committed a followup so the pane is always shown in the admin view, but hidden in the customer view if there is nothing to show. This reduces confusion for customers while taking into account the points raised in #2.

tr’s picture

tr commented

Sounds good to me. Thanks.

bwynants’s picture

bwynants commented

sounds right, thanks!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.